Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the module API async #86

Closed
NiklasEi opened this issue Feb 12, 2021 · 1 comment
Closed

Check the module API async #86

NiklasEi opened this issue Feb 12, 2021 · 1 comment

Comments

@NiklasEi
Copy link
Owner

The module lookup should not block the server on startup.
NiklasEi added a commit that referenced this issue May 8, 2021
@NiklasEi
Make it clearer which functions go against the API and wich just chec…
b7c672f 
…k the cache (#86)
@NiklasEi
Copy link
Owner Author

NiklasEi commented May 8, 2021 •
edited
Loading

I double-checked all facade functions and they are only used in async tasks. The blocked main threads should not be due to GameBox API calls.

This leaves #61

@NiklasEi NiklasEi closed this as completed May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NiklasEi