Skip to content

Commit cfc2678

Browse files
committed
Revert "Rename JSONRPCServer to JSONRPCRouter"
This reverts commit 1050871.
1 parent 4f9c239 commit cfc2678

File tree

3 files changed

+20
-11
lines changed

3 files changed

+20
-11
lines changed

internal/jsonrpc/router.go renamed to internal/jsonrpc/rpc_server.go

+10-8
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212
"time"
1313
)
1414

15-
type JSONRPCRouter struct {
15+
type JSONRPCServer struct {
1616
writer io.Writer
1717

1818
handlers map[string]*RPCHandler
@@ -22,14 +22,16 @@ type JSONRPCRouter struct {
2222
responseChannels map[int64]chan JSONRPCResponse
2323
}
2424

25-
func NewJSONRPCRouter(writer io.Writer, handlers map[string]*RPCHandler) *JSONRPCRouter {
26-
return &JSONRPCRouter{
27-
writer: writer,
28-
handlers: handlers,
25+
func NewJSONRPCServer(writer io.Writer, handlers map[string]*RPCHandler) *JSONRPCServer {
26+
return &JSONRPCServer{
27+
writer: writer,
28+
handlers: handlers,
29+
responseChannels: make(map[int64]chan JSONRPCResponse),
30+
nextId: atomic.Int64{},
2931
}
3032
}
3133

32-
func (s *JSONRPCRouter) Request(method string, params map[string]interface{}, result interface{}) *JSONRPCResponseError {
34+
func (s *JSONRPCServer) Request(method string, params map[string]interface{}, result interface{}) *JSONRPCResponseError {
3335
id := s.nextId.Add(1)
3436
request := JSONRPCRequest{
3537
JSONRPC: "2.0",
@@ -106,7 +108,7 @@ type JSONRPCMessage struct {
106108
ID *int64 `json:"id,omitempty"`
107109
}
108110

109-
func (s *JSONRPCRouter) HandleMessage(data []byte) error {
111+
func (s *JSONRPCServer) HandleMessage(data []byte) error {
110112
// Data will either be a JSONRPCRequest or JSONRPCResponse object
111113
// We need to determine which one it is
112114
var raw JSONRPCMessage
@@ -191,7 +193,7 @@ func (s *JSONRPCRouter) HandleMessage(data []byte) error {
191193
return s.writeResponse(response)
192194
}
193195

194-
func (s *JSONRPCRouter) writeResponse(response JSONRPCResponse) error {
196+
func (s *JSONRPCServer) writeResponse(response JSONRPCResponse) error {
195197
responseBytes, err := json.Marshal(response)
196198
if err != nil {
197199
return err

jsonrpc.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ func (w *DataChannelWriter) Write(data []byte) (int, error) {
4040
return len(data), nil
4141
}
4242

43-
func NewDataChannelJsonRpcRouter(dataChannel *webrtc.DataChannel) *jsonrpc.JSONRPCRouter {
44-
return jsonrpc.NewJSONRPCRouter(
43+
func NewDataChannelJsonRpcServer(dataChannel *webrtc.DataChannel) *jsonrpc.JSONRPCServer {
44+
return jsonrpc.NewJSONRPCServer(
4545
NewDataChannelWriter(dataChannel),
4646
rpcHandlers,
4747
)

webrtc.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,14 @@ func newSession() (*Session, error) {
7575
switch d.Label() {
7676
case "rpc":
7777
session.RPCChannel = d
78-
rpcServer := NewDataChannelJsonRpcRouter(d)
78+
fmt.Println("starting rpc server")
79+
rpcServer := NewDataChannelJsonRpcServer(d)
80+
d.OnError(func(err error) {
81+
fmt.Println("rpc error", err)
82+
})
83+
d.OnClose(func() {
84+
fmt.Println("rpc closed")
85+
})
7986
d.OnMessage(func(msg webrtc.DataChannelMessage) {
8087
go rpcServer.HandleMessage(msg.Data)
8188
})

0 commit comments

Comments
 (0)