Fix CedRawIO with sonpy >= 1.9.12 and re-enable the CED tests (#1891)

* Fix CedRawIO with sonpy >= 1.9.12

sonpy 1.9.12 dropped the 'lib' namespace that cedrawio.py used, so every
sonpy.lib.* access raised AttributeError. Resolve the namespace once,
probing sonpy.lib, sonpy and sonpy.sonpy in turn: the last is needed on
Linux, where the 1.9.12 wheel ships an empty __init__.py.

Refs #1890

Co-authored-by: Cursor <cursoragent@cursor.com>

* Use a single sonpy availability check in both CED tests

test_cedio.py replicated the old per-platform sonpy dispatch and skipped
with 1.9.12; test_cedrawio.py guarded on a bare 'import sonpy', which
succeeds with 1.9.12 so the test would run and fail. Both now delegate to
_get_sonpy_namespace().

Refs #1890

Co-authored-by: Cursor <cursoragent@cursor.com>

* Install sonpy in CI where usable wheels exist

The test extra declared sonpy;python_version<'3.10' while the project
requires >=3.10, so sonpy was never installed and the CED tests never ran.
Target the platform/version combinations sonpy actually publishes wheels
for; the sdist ships a Windows .pyd and is not usable elsewhere.

Refs #1890

Co-authored-by: Cursor <cursoragent@cursor.com>

* Resolve the sonpy submodule with find_spec instead of try/except

Per review: find_spec verifies sonpy.sonpy without importing it, so the
try/except goes away. Two guards are needed for that to hold: importlib.util
must be imported explicitly, and find_spec raises ModuleNotFoundError if
sonpy is not a package, so check __path__ first. Probing after the first two
candidates also means the submodule is only imported on Linux >= 1.9.12.

Refs #1890

Co-authored-by: Cursor <cursoragent@cursor.com>

* Document the sonpy platform constraint in the CedRawIO docstring

sonpy only ships wheels for Windows, and for Linux and macOS from 3.14 on,
so neo[ced] silently resolves to nothing elsewhere. Say so, and point users
at Spike2RawIO for .smr files, which needs no sonpy.

Refs #1890

Co-authored-by: Cursor <cursoragent@cursor.com>

* Handle sonpy.lib as an attribute, not a submodule

find_spec() cannot see sonpy.lib in <=1.9.5: __init__.py binds the
extension module via 'import sonpy.<platform>.sonpy as lib', so there is
no sonpy/lib.py for find_spec to find. Use getattr for that candidate and
keep find_spec for the top-level guard and for the nested sonpy.sonpy of
the 1.9.12 Linux wheel.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Drop @cache from _get_sonpy_namespace

After the first call find_spec() and import_module() are sys.modules
lookups, so the decorator saves ~1.2us on a path the import system
already caches. It cannot help the one path with real cost either:
functools.cache does not memoize exceptions, so find_spec()'s full
sys.path scan on a missing sonpy re-runs on every call regardless.
It also forces cache_clear() into any test of this function.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: AxelNoun

neo/rawio/cedrawio.py

@@ -19,6 +19,9 @@
 Author : Samuel Garcia
 """
 
+import importlib
+import importlib.util
+
 import numpy as np
 
 from .baserawio import (
@@ -31,6 +34,32 @@
 )
 
 
+def _get_sonpy_namespace():
+    """Return the sonpy namespace exposing SonFile, whatever the installed layout."""
+    if importlib.util.find_spec("sonpy") is None:
+        raise ImportError("sonpy is not installed. Install it with `pip install sonpy`.")
+
+    sonpy = importlib.import_module("sonpy")
+
+    # <= 1.9.5 binds the extension module as an attribute, not a submodule,
+    # so find_spec("sonpy.lib") cannot see it.
+    lib = getattr(sonpy, "lib", None)
+    if lib is not None and hasattr(lib, "SonFile"):
+        return lib
+
+    # >= 1.9.12 on Windows/macOS re-exports into the package namespace.
+    if hasattr(sonpy, "SonFile"):
+        return sonpy
+
+    # >= 1.9.12 on Linux ships an empty __init__.py.
+    if importlib.util.find_spec("sonpy.sonpy") is not None:
+        nested = importlib.import_module("sonpy.sonpy")
+        if hasattr(nested, "SonFile"):
+            return nested
+
+    raise ImportError("sonpy is installed but exposes no SonFile.")
+
+
 class CedRawIO(BaseRawIO):
     """
     Class for reading data from CED (Cambridge Electronic Design) spike2.
@@ -48,6 +77,13 @@ class CedRawIO(BaseRawIO):
 
     * This IO reads smr and smrx files
 
+    * sonpy is installed by the ``ced`` extra, but upstream only publishes wheels for Windows,
+      and for Linux and macOS from Python 3.14 onwards. Elsewhere the extra resolves to nothing
+      installable and this class raises an ImportError naming the constraint on first use; the
+      PyPI source distribution ships a Windows binary and is not usable.
+
+    * Old smr files can be read without sonpy using Spike2RawIO. Only smrx requires this class.
+
     """
 
     extensions = ["smr", "smrx"]
@@ -67,9 +103,9 @@ def _source_name(self):
         return self.filename
 
     def _parse_header(self):
-        import sonpy
+        sonpy_ns = _get_sonpy_namespace()
 
-        self.smrx_file = sonpy.lib.SonFile(sName=str(self.filename), bReadOnly=True)
+        self.smrx_file = sonpy_ns.SonFile(sName=str(self.filename), bReadOnly=True)
         smrx = self.smrx_file
 
         self._time_base = smrx.GetTimeBase()
@@ -82,7 +118,7 @@ def _parse_header(self):
         for chan_ind in range(smrx.MaxChannels()):
             chan_type = smrx.ChannelType(chan_ind)
             chan_id = str(chan_ind)
-            if chan_type == sonpy.lib.DataType.Adc:
+            if chan_type == sonpy_ns.DataType.Adc:
                 physical_chan = smrx.PhysicalChannel(chan_ind)
                 divide = smrx.ChannelDivide(chan_ind)
                 if self.take_ideal_sampling_rate:
@@ -105,13 +141,13 @@ def _parse_header(self):
                 buffer_id = ""
                 signal_channels.append((ch_name, chan_id, sr, dtype, units, gain, offset, stream_id, buffer_id))
 
-            elif chan_type == sonpy.lib.DataType.AdcMark:
+            elif chan_type == sonpy_ns.DataType.AdcMark:
                 # spike and waveforms : only spike times is used here
                 ch_name = smrx.GetChannelTitle(chan_ind)
                 first_time = smrx.FirstTime(chan_ind, 0, max_time)
                 max_time = smrx.ChannelMaxTime(chan_ind)
                 divide = smrx.ChannelDivide(chan_ind)
-                # here we don't use filter (sonpy.lib.MarkerFilter()) so we get all marker
+                # here we don't use filter (sonpy_ns.MarkerFilter()) so we get all marker
                 wave_marks = smrx.ReadWaveMarks(chan_ind, int(max_time / divide), 0, max_time)
 
                 # here we load in memory all spike once because the access is really slow

neo/test/iotest/test_cedio.py

@@ -1,17 +1,10 @@
 import unittest
-from platform import system
-from sys import maxsize
 
 try:
-    if system() == "Windows":
-        if maxsize > 2**32:
-            import sonpy.amd64.sonpy
-        else:
-            import sonpy.win32.sonpy
-    elif system() == "Darwin":
-        import sonpy.darwin.sonpy
-    elif system() == "Linux":
-        import sonpy.linux.sonpy
+    from neo.rawio.cedrawio import _get_sonpy_namespace
+
+    # Raises ImportError if sonpy is missing or exposes no usable namespace.
+    _get_sonpy_namespace()
     from neo.io import CedIO
 except ImportError:
     HAVE_SONPY = False

neo/test/rawiotest/test_cedrawio.py

@@ -5,7 +5,10 @@
 from neo.test.rawiotest.common_rawio_test import BaseTestRawIO
 
 try:
-    import sonpy
+    from neo.rawio.cedrawio import _get_sonpy_namespace
+
+    # Raises ImportError if sonpy is missing or exposes no usable namespace.
+    _get_sonpy_namespace()
 
     HAVE_SONPY = True
 except ImportError:

pyproject.toml

@@ -64,7 +64,7 @@ test = [
     "coverage",
     "coveralls",
     "pillow",
-    "sonpy;python_version<'3.10'",
+    "sonpy; platform_system=='Windows' or python_version>='3.14'",
     "pynwb",
     "probeinterface",
     "zugbruecke>=0.2",