Skip to content

metaflow-dev up strictly requires the docker CLI by Docker (rather than alternatives such as Orbstack)Β #2737

@seanturner026

Description

@seanturner026

The metaflow local documentation notes that docker is a requirement. In theory this is the ability to run docker containers; however, a Make Target checks that docker by Docker is available and fails if not. This blocks anyone not using docker by Docker (e.g. Orbstack) from running metaflow-dev up.

https://docs.metaflow.org/getting-started/devstack

https://github.com/Netflix/metaflow/blob/master/devtools/Makefile#L76-L80

uv init metaflow-test
uv add metaflow
uv run metaflow-dev up
πŸ” Checking Docker daemon...
Unable to find application named 'Docker'
❌ Please start Docker Desktop
make: *** [check-docker] Error 1
# docker is running
docker info
Client:
 Version:    28.3.3
 Context:    orbstack

# omitted for brevity
Server:
 Containers: 4
  Running: 2
  Paused: 0
  Stopped: 2
 Images: 35

I was able to circumvent this issue by cloning metaflow and commenting the check-docker Target and running make up

diff
diff --git i/devtools/Makefile w/devtools/Makefile
index 0a85237c..f72dfa75 100644
--- i/devtools/Makefile
+++ w/devtools/Makefile
@@ -67,18 +67,18 @@ install-helm:
                echo "βœ… Helm is already installed at $$(command -v helm)"; \
        fi

-check-docker:
-       @if ! command -v docker >/dev/null 2>&1; then \
-               echo "❌ Docker is not installed. Please install Docker first: https://docs.docker.com/get-docker/"; \
-               exit 1; \
-       fi
-       @echo "πŸ” Checking Docker daemon..."
-       @if [ "$(shell uname)" = "Darwin" ]; then \
-               open -a Docker || (echo "❌ Please start Docker Desktop" && exit 1); \
-       else \
-                docker info >/dev/null 2>&1 || (echo "❌ Docker daemon is not running." && exit 1); \
-       fi
-       @echo "βœ… Docker is running"
+# check-docker:
+#      @if ! command -v docker >/dev/null 2>&1; then \
+#              echo "❌ Docker is not installed. Please install Docker first: https://docs.docker.com/get-docker/"; \
+#              exit 1; \
+#      fi
+#      @echo "πŸ” Checking Docker daemon..."
+#      @if [ "$(shell uname)" = "Darwin" ]; then \
+#              open -a Docker || (echo "❌ Please start Docker Desktop" && exit 1); \
+#      else \
+#                 docker info >/dev/null 2>&1 || (echo "❌ Docker daemon is not running." && exit 1); \
+#      fi
+#      @echo "βœ… Docker is running"

 install-brew:
        @if [ "$(shell uname)" = "Darwin" ] && ! command -v brew >/dev/null 2>&1; then \
@@ -175,7 +175,7 @@ dashboard:
        @$(MINIKUBE) dashboard

 # make shell is symlinked to metaflow-dev shell by metaflow
-up: install-brew check-docker install-curl install-gum setup-minikube install-helm setup-tilt
+up: install-brew install-curl install-gum setup-minikube install-helm setup-tilt
        @echo "πŸš€ Starting up (may require sudo access)..."
        @mkdir -p $(DEVTOOLS_DIR)
        @echo '#!/bin/bash' > $(DEVTOOLS_DIR)/start.sh

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions