Skip to content

Commit b490242

Browse files
Fix analytics (#2869)
Fix analytics, so we'll no longer track information for users, who have not allowed us to do so. There are several problems: * Whenever the terminal is not interactive and we do not know if user allows us to track them, we set the value of TrackExceptions to true. Also we immediately send information to Analytics that we've set the value to true. So all CI builds are tracked as new users, as we start a session for them and send the value of TrackExceptions (enabled). * `setStatus` method almost always sends data to Analytics. This method should not send information. It does not care if we have allowed to be tracked - it always sends data. Remove this logic. * `tns usage-reporting <value>` and `tns error-reporting <values>` always send information to Analytics - in fact the commands are calling "setStatus", that's why they send information. In order to track them, use the "trackFeature" method which will track information ONLY when user had allowed this. * Fix `getStatus` method which had incorrect behavior - the if has been using the values of the enum (0,1,2) and we were getting in the body of the if statement in a very inaccurate cases. * Remove unit tests for `setStatus` and add new ones for checkConsent logic.
1 parent d9f2ab4 commit b490242

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

0 commit comments

Comments
 (0)