wrong calculation for vulkan buffer 4-byte alignment in vkCmdUpdateBuffer

[BlurryLight]

nvrhi/src/vulkan/vulkan-buffer.cpp

Line 112 in 01a90aa

size += size % 4;

nvrhi/src/vulkan/vulkan-buffer.cpp

Line 440 in 01a90aa

thisGulpSize += thisGulpSize % 4;

take 5 byte as example , 5 + (5 % 4) = 6, which is not multiple of 4.

An easily reproducible code is as follows:

        nvrhi::BufferDesc desc{};
        desc.byteSize = 5;
        desc.keepInitialState = true;
        desc.initialState = nvrhi::ResourceStates::Common; // some boilerplate...
        auto buf = GetDevice()->createBuffer(desc);
        std::array<uint8_t, 5> data{0, 1, 2, 3, 4};
        m_CommandList->writeBuffer(buf, data.data(),sizeof(data)); // write 5 bytes

vulkan validation layer catchs the error:

WARNING: [Vulkan: location=0xe9aa8ae3 code=0, layerPrefix='Validation'] Validation Error: [ VUID-vkCmdUpdateBuffer-dataSize-00038 ] Object 0: handle = 0x275ca6f9400, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xe9aa8ae3 | vkCmdUpdateBuffer() parameter, VkDeviceSize dataSize (0x6), is not a multiple of 4. The Vulkan spec states: dataSize must be a multiple of 4 (https://vulkan.lunarg.com/doc/view/1.3.243.0/windows/1.3-extensions/vkspec.html#VUID-vkCmdUpdateBuffer-dataSize-00038)

[apanteleev]

Fixed. Thank you for reporting this issue.