Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbounded memory&frame generation time growth in rasterization pipeline #459

Closed
Hyiker opened this issue Dec 28, 2024 · 1 comment · Fixed by #461
Closed

Unbounded memory&frame generation time growth in rasterization pipeline #459

Hyiker opened this issue Dec 28, 2024 · 1 comment · Fixed by #461

Comments

@Hyiker
Copy link
Contributor

Hyiker commented Dec 28, 2024

Falcor 7 & 8's memory and cpu frame time grow fast and infinitely as time goes on. The immediate cause is that GraphicsStateGraph.mGraph(In GraphicsState.h) having unbounded growing nodes, such that scanForMatchingNode takes longer time and failed to find the desired node every single search in each frame. The root cause is in GraphicsState::getGSO, where some of the properties(in my case, GraphicsStateObjectDesc::pBlendState is alway null) of mDesc are not properly set but mpDevice->createGraphicsStateObject updates the descriptor passed by value afterwards. This leads to cmpFunc returns false all the time.

Luckily, a short fix, appending mDesc = pGso->getDesc(); after line 112 in GraphicsState.cpp could save the day.

@tomas-davidovic
Copy link
Collaborator

Thank you for pointing this out.
We've updated this in the internal version, if you open a PR here, we will merge it into the public one as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants