Official NVAPI R560 release is broken!!!

[levicki]

@sujatas-NV @planke-NV @arunimam-NV

nvapi.h includes nvapi_lite_salstart.h which in turn uses a symbol NvAPI_Status which is only defined later in nvapi_lite_common.h (which also includes nvapi_lite_salstart.h before it defines the symbol).

This level of software engineering incompetence with basic C/C++ stuff such as header files, order of including, avoiding cyclic inclusions, and symbols being used before defining is staggering even when it doesn't result in unusable release -- I'd expect it from students learning C in high school class, not from NVIDIA employees even if those are new hires.

You all should be ashamed of yourself for allowing this to be released in such a broken state both here and in R560-developer.zip download from developer.nvidia.com.

Bug ID #4919663.

[ReenigneArcher]

I suspect this is the cause of my build errors in the following as well.

• build(deps): bump third-party/nvapi-open-source-sdk from cce4e90 to c873858 LizardByte/Sunshine#3015
• build(deps): move nvapi to official nvidia repo LizardByte/Sunshine#3725

I have my own dist of this (https://github.com/LizardByte/nvapi-open-source-sdk) which I created before the official repo existed. I am now trying to move to the official one, but the R555 version is missing nvapi_interface.h so it cannot be used as is. https://github.com/NVIDIA/nvapi/tree/fab23132652026fe9bb42c2c4cac452bddfcc5a9

At a bare minimum would it be possible for a maintainer to edit the git history and fix the R555 version?