Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[BUG]: Cannot import modulus.launch.logging #734

Open
simonbyrne opened this issue Dec 7, 2024 · 0 comments
Open

🐛[BUG]: Cannot import modulus.launch.logging #734

simonbyrne opened this issue Dec 7, 2024 · 0 comments
Assignees
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@simonbyrne
Copy link
Contributor

simonbyrne commented Dec 7, 2024

Version

0.9.0

On which installation method(s) does this occur?

Docker

Describe the issue

If I attempt to import modulus.launch.logging, I get an error that MLFlow is not installed (note, I am not attempting to load modulus.launch.logging.mlflow)

The problem appears to be that the __init__.py loads mlflow as a submodule:

from .mlflow import initialize_mlflow

Minimum reproducible example

Using the current NGC container (24.12)

import modulus.launch.logging

Relevant log output

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/modulus/launch/logging/mlflow.py", line 25, in <module>
    import mlflow  # noqa: F401 for docs
ModuleNotFoundError: No module named 'mlflow'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.10/dist-packages/modulus/launch/logging/__init__.py", line 19, in <module>
    from .mlflow import initialize_mlflow
  File "/usr/local/lib/python3.10/dist-packages/modulus/launch/logging/mlflow.py", line 29, in <module>
    raise ImportError(
ImportError: These utilities require the MLFlow library. Install MLFlow using `pip install mlflow`. For more info, refer: https://www.mlflow.org/docs/2.5.0/quickstart.html#install-mlflow

Environment details

@simonbyrne simonbyrne added ? - Needs Triage Need team to review and classify bug Something isn't working labels Dec 7, 2024
@ktangsali ktangsali self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants