Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use k8s-test-infra devel image #62

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

ArangoGutierrez
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez commented Jan 26, 2024

This uses the images defined in https://github.com/NVIDIA/k8s-test-infra over per-project images.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@elezar
Copy link
Member

elezar commented Jan 26, 2024

Please also see the related comments here: NVIDIA/k8s-test-infra#3 (comment)

@ArangoGutierrez
Copy link
Collaborator Author

Please also see the related comments here: NVIDIA/k8s-test-infra#3 (comment)

NVIDIA/k8s-test-infra#4

@elezar
Copy link
Member

elezar commented Jan 26, 2024

The linked PR looks good. Please update the use of GOLANG_VERSION.

Makefile Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment for clarity.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments w.r.t aligning with other repos.

.github/workflows/build-images.yaml Outdated Show resolved Hide resolved
.github/workflows/golang-build.yaml Outdated Show resolved Hide resolved
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ArangoGutierrez ArangoGutierrez merged commit b6c7aae into NVIDIA:main Jan 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants