From 41fe1cb2b757eb428a358b294b1d9726667e8add Mon Sep 17 00:00:00 2001 From: Kevin Klues Date: Sun, 9 Mar 2025 21:18:09 -0700 Subject: [PATCH] Remove unnused setting in daemon claim config Signed-off-by: Kevin Klues --- api/nvidia.com/resource/v1beta1/computedomainconfig.go | 4 ---- cmd/compute-domain-controller/resourceclaimtemplate.go | 1 - templates/compute-domain-daemon-claim-template.tmpl.yaml | 1 - 3 files changed, 6 deletions(-) diff --git a/api/nvidia.com/resource/v1beta1/computedomainconfig.go b/api/nvidia.com/resource/v1beta1/computedomainconfig.go index b83417cdb..0c18df7f4 100644 --- a/api/nvidia.com/resource/v1beta1/computedomainconfig.go +++ b/api/nvidia.com/resource/v1beta1/computedomainconfig.go @@ -58,7 +58,6 @@ func (c *ComputeDomainChannelConfig) Validate() error { // ComputeDomainDaemonConfig holds the set of parameters for configuring an ComputeDomainDaemon. type ComputeDomainDaemonConfig struct { metav1.TypeMeta `json:",inline"` - NumNodes int `json:"numNodes"` DomainID string `json:"domainID"` } @@ -79,9 +78,6 @@ func (c *ComputeDomainDaemonConfig) Normalize() error { // Validate ensures that ComputeDomainDaemonConfig has a valid set of values. func (c *ComputeDomainDaemonConfig) Validate() error { - if c.NumNodes <= 0 { - return fmt.Errorf("numNodes must be greater than or equal to 1") - } if c.DomainID == "" { return fmt.Errorf("domainID cannot be empty") } diff --git a/cmd/compute-domain-controller/resourceclaimtemplate.go b/cmd/compute-domain-controller/resourceclaimtemplate.go index eb4b09e92..5a06598c4 100644 --- a/cmd/compute-domain-controller/resourceclaimtemplate.go +++ b/cmd/compute-domain-controller/resourceclaimtemplate.go @@ -290,7 +290,6 @@ func (m *DaemonSetResourceClaimTemplateManager) Create(ctx context.Context, name } daemonConfig := nvapi.DefaultComputeDomainDaemonConfig() - daemonConfig.NumNodes = cd.Spec.NumNodes daemonConfig.DomainID = string(cd.UID) templateData := ResourceClaimTemplateTemplateData{ diff --git a/templates/compute-domain-daemon-claim-template.tmpl.yaml b/templates/compute-domain-daemon-claim-template.tmpl.yaml index 07f796d34..3aef68168 100644 --- a/templates/compute-domain-daemon-claim-template.tmpl.yaml +++ b/templates/compute-domain-daemon-claim-template.tmpl.yaml @@ -22,5 +22,4 @@ spec: parameters: apiVersion: {{ .DaemonConfig.APIVersion }} kind: {{ .DaemonConfig.Kind }} - numNodes: {{ .DaemonConfig.NumNodes }} domainID: {{ .DaemonConfig.DomainID }}