Skip to content

Commit c8dd0cc

Browse files
committed
USE GIT_COMMIT in container builds
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
1 parent 45c8844 commit c8dd0cc

File tree

21 files changed

+112
-0
lines changed

21 files changed

+112
-0
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ $(DRIVER_BUILD_TARGETS):
171171
--build-arg DRIVER_BRANCH="$(DRIVER_BRANCH)" \
172172
--build-arg CUDA_VERSION="$(CUDA_VERSION)" \
173173
--build-arg CVE_UPDATES="$(CVE_UPDATES)" \
174+
--build-arg GIT_COMMIT="$(GIT_COMMIT)" \
174175
$(DOCKER_BUILD_ARGS) \
175176
--file $(DOCKERFILE) \
176177
$(CURDIR)/$(SUBDIR)

rhel10/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ ARG DRIVER_VERSION
4141
ENV DRIVER_VERSION=$DRIVER_VERSION
4242
ARG DRIVER_BRANCH
4343
ENV DRIVER_BRANCH=$DRIVER_BRANCH
44+
ARG GIT_COMMIT
4445

4546
# Arg to indicate if driver type is either of passthrough/baremetal or vgpu
4647
ARG DRIVER_TYPE=passthrough
@@ -97,6 +98,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
9798
LABEL name="NVIDIA Driver Container"
9899
LABEL vendor="NVIDIA"
99100
LABEL version="${DRIVER_VERSION}"
101+
LABEL vcs-ref="${GIT_COMMIT}"
100102
LABEL release="N/A"
101103
LABEL summary="Provision the NVIDIA driver through containers"
102104
LABEL description="See summary"

rhel10/precompiled/Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,8 @@ ARG BUILD_ARCH
9393
ARG TARGET_ARCH
9494
ENV TARGETARCH=${TARGET_ARCH}
9595

96+
ARG GIT_COMMIT
97+
9698
# Force using provided RHSM registration
9799
ENV SMDEV_CONTAINER_OFF=1
98100

@@ -172,6 +174,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
172174
LABEL name="NVIDIA Driver Container"
173175
LABEL vendor="NVIDIA"
174176
LABEL version="${DRIVER_VERSION}"
177+
LABEL vcs-ref="${GIT_COMMIT}"
175178
LABEL release="${KERNEL_VERSION}-${OS_TAG}"
176179
LABEL summary="Provision the NVIDIA driver through containers"
177180
LABEL description="See summary"

rhel10/precompiled/Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
GIT_COMMIT ?= $(shell git describe --match="" --dirty --long --always --abbrev=40 2> /dev/null || echo "")
2+
13
RHEL_VERSION ?= 10.0
24
RHEL_VERSION_MAJOR = $(shell echo "${RHEL_VERSION}" | awk -F. '{print $$1}')
35

@@ -70,6 +72,7 @@ image: rhsm-register
7072
--build-arg DRIVER_STREAM_TYPE=${DRIVER_STREAM_TYPE} \
7173
--build-arg BASE_URL=${BASE_URL} \
7274
--build-arg OS_TAG=${OS_TAG} \
75+
--build-arg GIT_COMMIT=${GIT_COMMIT} \
7376
--tag ${IMAGE_REGISTRY}/${IMAGE_NAME}:${DRIVER_VERSION}-${KERNEL_VERSION_TAG}-${OS_TAG} \
7477
--progress=plain \
7578
--file ${DOCKERFILE} .

rhel8/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ ARG DRIVER_VERSION
3535
ENV DRIVER_VERSION=$DRIVER_VERSION
3636
ARG DRIVER_BRANCH
3737
ENV DRIVER_BRANCH=$DRIVER_BRANCH
38+
ARG GIT_COMMIT
3839

3940
# Arg to indicate if driver type is either of passthrough/baremetal or vgpu
4041
ARG DRIVER_TYPE=passthrough
@@ -90,6 +91,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
9091
LABEL name="NVIDIA Driver Container"
9192
LABEL vendor="NVIDIA"
9293
LABEL version="${DRIVER_VERSION}"
94+
LABEL vcs-ref="${GIT_COMMIT}"
9395
LABEL release="N/A"
9496
LABEL summary="Provision the NVIDIA driver through containers"
9597
LABEL description="See summary"

rhel8/precompiled/Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ ENV DRIVER_VERSION=${DRIVER_VERSION}
6767
ARG TARGET_ARCH=''
6868
ENV TARGETARCH=${TARGET_ARCH}
6969

70+
ARG GIT_COMMIT
71+
7072
# Force using provided RHSM registration
7173
ENV SMDEV_CONTAINER_OFF=1
7274

@@ -138,6 +140,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
138140
LABEL name="NVIDIA Driver Container"
139141
LABEL vendor="NVIDIA"
140142
LABEL version="${DRIVER_VERSION}"
143+
LABEL vcs-ref="${GIT_COMMIT}"
141144
LABEL release="N/A"
142145
LABEL summary="Provision the NVIDIA driver through containers"
143146
LABEL description="See summary"

rhel8/precompiled/Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
DOCKERFILE = Dockerfile
2+
GIT_COMMIT ?= $(shell git describe --match="" --dirty --long --always --abbrev=40 2> /dev/null || echo "")
23
RHEL_VERSION ?= 8.6
34
CUDA_VERSION ?= 12.6.0
45
CUDA_DIST ?= ubi8
@@ -52,6 +53,7 @@ image: rhsm-register
5253
--build-arg DRIVER_TOOLKIT_IMAGE=${DRIVER_TOOLKIT_IMAGE} \
5354
--build-arg DRIVER_TYPE=${DRIVER_TYPE} \
5455
--build-arg BASE_URL=${BASE_URL} \
56+
--build-arg GIT_COMMIT=${GIT_COMMIT} \
5557
--tag ${IMAGE_REGISTRY}/${IMAGE_NAME}:${DRIVER_VERSION}-${KERNEL_VERSION}-${OS_TAG} \
5658
--progress=plain \
5759
--file ${DOCKERFILE} .

rhel9/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ ARG DRIVER_VERSION
4040
ENV DRIVER_VERSION=$DRIVER_VERSION
4141
ARG DRIVER_BRANCH
4242
ENV DRIVER_BRANCH=$DRIVER_BRANCH
43+
ARG GIT_COMMIT
4344

4445
# Arg to indicate if driver type is either of passthrough/baremetal or vgpu
4546
ARG DRIVER_TYPE=passthrough
@@ -96,6 +97,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
9697
LABEL name="NVIDIA Driver Container"
9798
LABEL vendor="NVIDIA"
9899
LABEL version="${DRIVER_VERSION}"
100+
LABEL vcs-ref="${GIT_COMMIT}"
99101
LABEL release="N/A"
100102
LABEL summary="Provision the NVIDIA driver through containers"
101103
LABEL description="See summary"

rhel9/precompiled/Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,8 @@ ARG BUILD_ARCH
9393
ARG TARGET_ARCH
9494
ENV TARGETARCH=${TARGET_ARCH}
9595

96+
ARG GIT_COMMIT
97+
9698
# Force using provided RHSM registration
9799
ENV SMDEV_CONTAINER_OFF=1
98100

@@ -172,6 +174,7 @@ LABEL io.k8s.display-name="NVIDIA Driver Container"
172174
LABEL name="NVIDIA Driver Container"
173175
LABEL vendor="NVIDIA"
174176
LABEL version="${DRIVER_VERSION}"
177+
LABEL vcs-ref="${GIT_COMMIT}"
175178
LABEL release="${KERNEL_VERSION}-${OS_TAG}"
176179
LABEL summary="Provision the NVIDIA driver through containers"
177180
LABEL description="See summary"

rhel9/precompiled/Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
GIT_COMMIT ?= $(shell git describe --match="" --dirty --long --always --abbrev=40 2> /dev/null || echo "")
2+
13
RHEL_VERSION ?= 9.4
24
RHEL_VERSION_MAJOR = $(shell echo "${RHEL_VERSION}" | awk -F. '{print $$1}')
35

@@ -70,6 +72,7 @@ image: rhsm-register
7072
--build-arg DRIVER_STREAM_TYPE=${DRIVER_STREAM_TYPE} \
7173
--build-arg BASE_URL=${BASE_URL} \
7274
--build-arg OS_TAG=${OS_TAG} \
75+
--build-arg GIT_COMMIT=${GIT_COMMIT} \
7376
--tag ${IMAGE_REGISTRY}/${IMAGE_NAME}:${DRIVER_VERSION}-${KERNEL_VERSION_TAG}-${OS_TAG} \
7477
--progress=plain \
7578
--file ${DOCKERFILE} .

0 commit comments

Comments
 (0)