Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exporter-metrics-volume to daemonset.yaml #442

Open
ysk24ok opened this issue Jan 15, 2025 · 0 comments
Open

Move exporter-metrics-volume to daemonset.yaml #442

ysk24ok opened this issue Jan 15, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@ysk24ok
Copy link

ysk24ok commented Jan 15, 2025

Is this a new feature, an improvement, or a change to existing functionality?

Change

Please provide a clear description of the problem this feature solves

As of 3.3.9-3.6.1, exporter-metrics-volume configMapVolume and volumeMount is specified in values.yaml
https://github.com/NVIDIA/dcgm-exporter/blob/3.3.9-3.6.1/deployment/values.yaml#L143-L154

These are treated as default values, which mean you have to specify the exporter-metrics-volume in your values.yaml when you specify another volume because the default values are overridden.

For reference, here's my values.yaml. nvidia-install-dir-host volume is needed in my environment (ref: #385 (comment)).

extraHostVolumes:
- name: nvidia-install-dir-host
  hostPath: /home/kubernetes/bin/nvidia
extraVolumeMounts:
- name: exporter-metrics-volume
  mountPath: /etc/dcgm-exporter/dcp-metrics-included.csv
  subPath: dcp-metrics-included.csv
- name: nvidia-install-dir-host
  mountPath: /usr/local/nvidia
  readOnly: true

Feature Description

Uses don't have to specify exporter-metrics-volume in their values.yaml even when they have another volume.

Describe your ideal solution

Moving exporter-metrics-volume configMapVolume and volumeMount out of values.yaml to templates/daemonset.yaml.

Since exporter-metrics-volume is required in any case, it makes sense if we have those values in the k8s yaml itself.

Additional context

No response

@ysk24ok ysk24ok added the enhancement New feature or request label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant