Skip to content

[FEA] Use warning flags #2662

@r-barnes

Description

@r-barnes

Which component requires the feature?

CUTLASS C++

Feature Request

Is your feature request related to a problem? Please describe.
Within Meta we've found that there are very high signal (and high ROI) warning flags that detect bugs at a high rate. We also compile all code with -Wall,-Werror along with more than 25 additional warning flags.

This quality bar can make importing third-party code, such as CUTLASS, challenging if it doesn't hold to the same standards.

I've recently done the requisite clean-up to enable -Wimplicit-fallthrough (this found many bugs in our codebase) in CUTLASS (#2324). I'm now trying to enable -Wimplicit-fallthrough globally for CUTLASS (#2661), but I don't see a list of compiler warning flags anywhere in the build system and, indeed, #151 states

It seems we accidentally dropped -Wall -Werror sometime in the past and we want to add it back for all the compilers we support in Linux, Windows, Clang without behind any flags.

That PR was abandoned.

I think it would be good for the dev team to add warnings back to CUTLASS. Ideally, this is a one time cost that increases the correctness of and confidence in the code.

Describe the solution you'd like
-Wall,-Werror enabled for at least a subset of compilers. A straight-forward place to add additional flags as related issues are driven down.

Describe alternatives you've considered
There are not good alternatives.

Additional context
N/A

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions