Forward-merge release/26.06 into main#1293
Open
rapids-bot[bot] wants to merge 1 commit into
Open
Conversation
This PR cleans #1252, so only the changes related to the OpenMP are present. ## Original description: `run_concurrent` in `cpp/src/pdlp/solve.cu` now dispatches the barrier and dual simplex workers as `#pragma omp task` inside a `#pragma omp taskgroup` instead of raw `std::thread`. PDLP still runs synchronously on the dispatching thread. MIP path (`omp_in_parallel()`): reuses the upstream `solve_mip` OMP team. Barrier and dual simplex now consume slots from the configured `num_cpu_threads` budget instead of spawning extra OS threads outside it. Stand-alone LP path: stands up a local `#pragma omp parallel + single` with the right number of workers. This PR also removes the confuscated `std::future` logic on the barrier on other PR. Authors: - Nicolas L. Guidotti (https://github.com/nguidotti) - Akif ÇÖRDÜK (https://github.com/akifcorduk) Approvers: - Alice Boucher (https://github.com/aliceb-nv) URL: #1291
Contributor
Author
|
FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.06 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.