-
Notifications
You must be signed in to change notification settings - Fork 180
Open
Labels
P1Medium priority - Should doMedium priority - Should docuda.bindingsEverything related to the cuda.bindings moduleEverything related to the cuda.bindings moduletestImprovements or additions to testsImprovements or additions to teststriageNeeds the team's attentionNeeds the team's attention
Description
During the bring-up #684 we noticed that some cuFile bindings require the internal thread pool to be activated, but on some systems they are not activated by default (for reasons I don't fully understand yet). We had to provide a custom json file pointed to by an env var CUFILE_ENV_PATH_JSON
to enforce the activation and make the tests pass on this local system.
We should consider either or both of the following approaches:
- Encode the activation criteria as a pytest skip decorator, so that the tests that need the threadpool to pass would be skipped
- Add a
cufile.json
file to the test directory (either statically or dynamically) and set upCUFILE_ENV_PATH_JSON
to force activating the thread pool
Metadata
Metadata
Assignees
Labels
P1Medium priority - Should doMedium priority - Should docuda.bindingsEverything related to the cuda.bindings moduleEverything related to the cuda.bindings moduletestImprovements or additions to testsImprovements or additions to teststriageNeeds the team's attentionNeeds the team's attention
Type
Projects
Status
Todo