Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc preview CI #380

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add doc preview CI #380

wants to merge 3 commits into from

Conversation

leofang
Copy link
Member

@leofang leofang commented Jan 12, 2025

Close #346.

@leofang leofang self-assigned this Jan 12, 2025
Copy link
Contributor

copy-pr-bot bot commented Jan 12, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang added documentation Improvements or additions to documentation P1 Medium priority - Should do CI/CD CI/CD infrastructure labels Jan 12, 2025
@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

/ok to test

@leofang leofang marked this pull request as draft January 12, 2025 04:17
@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

Looks like we need the org admin to approve another action. Waiting for response.

@leofang
Copy link
Member Author

leofang commented Jan 13, 2025

Looks like we need the org admin to approve another action. Waiting for response.

Admin has approved. Let's retry...

@leofang
Copy link
Member Author

leofang commented Jan 13, 2025

/ok to test

1 similar comment
@leofang
Copy link
Member Author

leofang commented Jan 13, 2025

/ok to test

@leofang leofang closed this Jan 13, 2025
@leofang leofang reopened this Jan 13, 2025
@leofang
Copy link
Member Author

leofang commented Jan 13, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 13, 2025

The action worked, but the way we launched it is not right. It couldn't get the PR number, so

@leofang
Copy link
Member Author

leofang commented Jan 14, 2025

It couldn't get the PR number

Discussed with the upstream maintainer (rossjrw/pr-preview-action#101), and unfortunately we'll have to be creative here. Luckily we have most things set up in the doc-build workflow, so we just need to check in the doc artifacts to the gh-pages branch and push.

@leofang
Copy link
Member Author

leofang commented Jan 16, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 16, 2025

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure documentation Improvements or additions to documentation P1 Medium priority - Should do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Add doc preview
1 participant