Skip to content

Commit 80e646e

Browse files
committed
test: remove B095 ruff rule and add zip(..., strict=True) in test code
1 parent 78c1449 commit 80e646e

File tree

7 files changed

+11
-11
lines changed

7 files changed

+11
-11
lines changed

cuda_bindings/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def discoverMembers(self, memberDict, prefix, seen=None):
125125
next_seen = set(seen)
126126
next_seen.add(self._name)
127127

128-
for memberName, memberType in zip(self._member_names, self._member_types):
128+
for memberName, memberType in zip(self._member_names, self._member_types, strict=True):
129129
if memberName:
130130
discovered.append(".".join([prefix, memberName]))
131131

cuda_bindings/tests/test_cuda.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ def test_cuda_pointer_attr():
432432
# List version
433433
err, attr_value_list_v2 = cuda.cuPointerGetAttributes(len(attr_type_list), attr_type_list, ptr)
434434
assert err == cuda.CUresult.CUDA_SUCCESS
435-
for attr1, attr2 in zip(attr_value_list, attr_value_list_v2):
435+
for attr1, attr2 in zip(attr_value_list, attr_value_list_v2, strict=True):
436436
assert str(attr1) == str(attr2)
437437

438438
# Test setting values
@@ -512,7 +512,7 @@ def test_cuda_mem_range_attr():
512512
attr_type_size_list, attr_type_list, len(attr_type_list), ptr, size
513513
)
514514
assert err == cuda.CUresult.CUDA_SUCCESS
515-
for attr1, attr2 in zip(attr_value_list, attr_value_list_v2):
515+
for attr1, attr2 in zip(attr_value_list, attr_value_list_v2, strict=True):
516516
assert str(attr1) == str(attr2)
517517

518518
(err,) = cuda.cuMemFree(ptr)

cuda_bindings/tests/test_cufile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ def test_buf_register_multiple_buffers():
318318
try:
319319
# Register all buffers
320320
flags = 0
321-
for buf_ptr, size in zip(buffers, buffer_sizes):
321+
for buf_ptr, size in zip(buffers, buffer_sizes, strict=True):
322322
buf_ptr_int = int(buf_ptr)
323323
cufile.buf_register(buf_ptr_int, size, flags)
324324

cuda_bindings/tests/test_nvjitlink.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535

3636
def _build_arch_ptx_parametrized_callable():
37-
av = tuple(zip(ARCHITECTURES, PTX_VERSIONS))
37+
av = tuple(zip(ARCHITECTURES, PTX_VERSIONS, strict=True))
3838
return pytest.mark.parametrize(
3939
("arch", "ptx_bytes"),
4040
[(a, (PTX_HEADER.format(VERSION=v, ARCH=a) + PTX_KERNEL).encode("utf-8")) for a, v in av],

cuda_core/tests/test_module.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,9 @@ class ExpectedStruct(ctypes.Structure):
248248
sizes = [p.size for p in arg_info]
249249
members = [getattr(ExpectedStruct, name) for name, _ in ExpectedStruct._fields_]
250250
expected_offsets = tuple(m.offset for m in members)
251-
assert all(actual == expected for actual, expected in zip(offsets, expected_offsets))
251+
assert all(actual == expected for actual, expected in zip(offsets, expected_offsets, strict=True))
252252
expected_sizes = tuple(m.size for m in members)
253-
assert all(actual == expected for actual, expected in zip(sizes, expected_sizes))
253+
assert all(actual == expected for actual, expected in zip(sizes, expected_sizes, strict=True))
254254

255255

256256
@pytest.mark.parametrize("nargs", [0, 1, 2, 3, 16])
@@ -274,8 +274,8 @@ class ExpectedStruct(ctypes.Structure):
274274
members = tuple(getattr(ExpectedStruct, f"arg_{i}") for i in range(nargs))
275275

276276
arg_info = krn.arguments_info
277-
assert all([actual.offset == expected.offset for actual, expected in zip(arg_info, members)])
278-
assert all([actual.size == expected.size for actual, expected in zip(arg_info, members)])
277+
assert all([actual.offset == expected.offset for actual, expected in zip(arg_info, members, strict=True)])
278+
assert all([actual.size == expected.size for actual, expected in zip(arg_info, members, strict=True)])
279279

280280

281281
def test_num_args_error_handling(deinit_all_contexts_function, cuda12_4_prerequisite_check):

cuda_core/tests/test_system.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,5 @@ def test_devices():
3535
expected_num_devices = handle_return(runtime.cudaGetDeviceCount())
3636
expected_devices = tuple(Device(device_id) for device_id in range(expected_num_devices))
3737
assert len(devices) == len(expected_devices), "Number of devices does not match expected value"
38-
for device, expected_device in zip(devices, expected_devices):
38+
for device, expected_device in zip(devices, expected_devices, strict=True):
3939
assert device.device_id == expected_device.device_id, "Device ID does not match expected value"

ruff.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ ignore = [
4040
"S101", # asserts
4141
"S311", # allow use of the random.* even though many are not cryptographically secure
4242
"S404", # allow importing the subprocess module
43-
"B905", # preserve the default behavior of `zip` without the explicit `strict` argument
4443
]
4544

4645
exclude = ["**/_version.py"]
@@ -52,6 +51,7 @@ exclude = ["**/_version.py"]
5251
"cuda_bindings/examples/**" = [
5352
"E722",
5453
"E501", # line too long
54+
"B905", # preserve the default behavior of `zip` without the explicit `strict` argument
5555
]
5656

5757
"cuda_bindings/tests/**" = [

0 commit comments

Comments
 (0)