Fix __is_primary_std_template for libc++
#6243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the wrong check, so that we would check for a specialization of `::cuda::std::iterator_traits` instead of `::std::iterator_traits` Fixes NVIDIA#6238
bernhardmgruber
approved these changes
Oct 15, 2025
|
@Artem-B please check to see whether this fixes your issue |
🥳 CI Workflow Results🟩 Finished in 2h 38m: Pass: 100%/84 | Total: 1d 15h | Max: 2h 37m | Hits: 85%/212068See results here. |
|
Successfully created backport PR for |
The patch does fix the reported problem. I've got more. Stay tuned. :-) |
|
|
miscco
added a commit
that referenced
this pull request
Oct 16, 2025
We were using the wrong check, so that we would check for a specialization of `::cuda::std::iterator_traits` instead of `::std::iterator_traits` Fixes #6238 (cherry picked from commit 813e75e) Co-authored-by: Michael Schellenberger Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the wrong check, so that we would check for a specialization of
::cuda::std::iterator_traitsinstead of::std::iterator_traitsFixes #6238