Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] te.Linear FP8 DGRAD+RS output bugfix #1412

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

denera
Copy link
Collaborator

@denera denera commented Jan 15, 2025

Description

This PR corrects a bug where the BF16 DGRAD+RS output was being incorrectly fed into a Float8Tensor constructor.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@denera denera added the bug Something isn't working label Jan 15, 2025
@denera denera requested review from cyanguwa and ksivaman January 15, 2025 22:00
@denera denera self-assigned this Jan 15, 2025
@denera
Copy link
Collaborator Author

denera commented Jan 15, 2025

/te-ci pytorch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant