Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it an option to compile activation functions with fast math #1410

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

guyueh1
Copy link
Contributor

@guyueh1 guyueh1 commented Jan 15, 2025

Description

Make it an option to compile activation functions with fast math. By default it's off and the activation kernels won't be compiled with fast math, which is consistent with previous behavior.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

setup.py Outdated Show resolved Hide resolved
transformer_engine/common/CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: guyueh1 <[email protected]>
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman
Copy link
Member

/te-ci pytorch

@ksivaman ksivaman merged commit 3d63cbb into NVIDIA:main Jan 15, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants