Skip to content

Commit f75b62f

Browse files
committed
remove redundant error message
Signed-off-by: Yukun He <[email protected]>
1 parent eb789c7 commit f75b62f

File tree

1 file changed

+1
-26
lines changed

1 file changed

+1
-26
lines changed

cpp/tensorrt_llm/thop/allreduceOp.cpp

Lines changed: 1 addition & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -988,33 +988,8 @@ class AllreduceOp
988988
bool ifFallbackToNCCL(size_t seq_len, size_t message_size_bytes, size_t max_workspace_size, bool is_auto)
989989
{
990990
// If messageSize is less than maxWorkspaceSize, use NCCL, regardless of the fusion type.
991-
if (message_size_bytes > max_workspace_size)
991+
if (message_size_bytes > max_workspace_size || !mIsP2PSupported || !mIsNVLINKSupported)
992992
{
993-
if (!is_auto)
994-
{
995-
TLLM_LOG_WARNING(
996-
"Since messageSize is greater than maxWorkspaceSize, fallback to AllReduceStrategy: NCCL");
997-
}
998-
return true;
999-
}
1000-
1001-
// If Peer to Peer is not supported, fallback to NCCL.
1002-
if (!mIsP2PSupported)
1003-
{
1004-
if (!is_auto)
1005-
{
1006-
TLLM_LOG_WARNING("Since Peer to Peer not supported, fallback to AllReduceStrategy: NCCL");
1007-
}
1008-
return true;
1009-
}
1010-
1011-
// If NVLINK is not supported, fallback to NCCL.
1012-
if (!mIsNVLINKSupported)
1013-
{
1014-
if (!is_auto)
1015-
{
1016-
TLLM_LOG_WARNING("Since NVLINK not supported, fallback to AllReduceStrategy: NCCL");
1017-
}
1018993
return true;
1019994
}
1020995
return false;

0 commit comments

Comments
 (0)