chore: minor changes

Signed-off-by: Tanisha goyal <tanishag@nvidia.com>

Author: tanishagoyal2

health-monitors/csp-health-monitor/pkg/triggerengine/trigger.go

@@ -363,9 +363,6 @@ func (e *Engine) mapMaintenanceEventToHealthEvent(
 		Metadata:           event.Metadata, // Pass along metadata
 		NodeName:           event.NodeName, // K8s node name
 		GeneratedTimestamp: timestamppb.New(time.Now()),
-		// TODO: Remove hardcoded processing strategy and make it configurable via the config file.
-		// PR: https://github.com/NVIDIA/NVSentinel/pull/641
-		ProcessingStrategy: pb.ProcessingStrategy_EXECUTE_REMEDIATION,
 	}
 
 	return healthEvent, nil

tests/csp_health_monitor_test.go

@@ -460,9 +460,6 @@ func TestCSPHealthMonitorStoreOnlyProcessingStrategy(t *testing.T) {
 	feature.Assess("Injecting PENDING maintenance event and verifying node was not cordoned when processing STORE_ONLY strategy", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
 		t.Log("Injecting GCP maintenance event with PENDING status into mock Cloud Logging API")
 
-		t.Logf("verify if pod has correct strategy configured")
-		time.Sleep(20 * time.Second)
-
 		scheduledStart := time.Now().Add(15 * time.Minute)
 		scheduledEnd := time.Now().Add(75 * time.Minute)
 		event := helpers.CSPMaintenanceEvent{
@@ -505,9 +502,8 @@ func TestCSPHealthMonitorStoreOnlyProcessingStrategy(t *testing.T) {
 		require.Eventually(t, func() bool {
 			events := helpers.GetMockEvents(t, c)
 			event, found := helpers.FindEventByNodeAndCheckName(events, testCtx.NodeName, "CSPMaintenance", false)
-			if found {
-				receivedEvent = event
-				return true
+			if !found {
+				return false
 			}
 
 			t.Log("Validating received CloudEvent")
@@ -524,7 +520,7 @@ func TestCSPHealthMonitorStoreOnlyProcessingStrategy(t *testing.T) {
 		require.NoError(t, err)
 
 		helpers.SetDeploymentArgs(ctx, client, "csp-health-monitor", helpers.NVSentinelNamespace, "maintenance-notifier", map[string]string{
-			"--processing-strategy": "EXECUTE_REMEDIATION",
+			"--processing-strategy": "STORE_ONLY",
 		})
 
 		helpers.WaitForDeploymentRollout(ctx, t, client, "csp-health-monitor", helpers.NVSentinelNamespace)

tests/helpers/kube.go

@@ -2359,7 +2359,7 @@ func setArgsOnContainer(container *v1.Container, args map[string]string) {
 	}
 }
 
-// RemoveDeploymentArgs removes environment variables from containers in a deployment.
+// RemoveDeploymentArgs removes arguments from containers in a deployment.
 // If containerName is empty, removes from all containers. Otherwise, removes only from the named container.
 // Uses retry.RetryOnConflict for automatic retry handling.
 func RemoveDeploymentArgs(