Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcasting Data Loader #16

Open
philipp-fischer opened this issue Sep 27, 2024 · 0 comments
Open

Broadcasting Data Loader #16

philipp-fischer opened this issue Sep 27, 2024 · 0 comments

Comments

@philipp-fischer
Copy link
Collaborator

philipp-fischer commented Sep 27, 2024

Currently, when using Energon with different types of parallelism, the user has to handle that in the framework around Energon.

If you are working with data parallelism (DP), tensor parallelism (TP), pipeline parallelism (PP) and other forms, on each global rank you'll have to

  • decide whether to initialize the data loader on that rank (if not, the rank needs to receive data via broadcasting)
  • compute the correct data rank to set the WorkerConfig of the loader

This feature request proposes to create a new wrapper around the energon methods get_savable_loader and get_train_dataset that shall handle these things automatically.

The user receives a virtual dataloader on each global rank. Internally, some of those will actually load the data from disk or object store while other ranks receive the data via NCCL broadcasting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant