Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Cleanup #814

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Misc Cleanup #814

merged 6 commits into from
Dec 20, 2024

Conversation

tmartin-gh
Copy link
Collaborator

@tmartin-gh tmartin-gh commented Dec 18, 2024

This PR adds a user configurable name to the tensor_t class and cleans up #define's in various MatX headers so they hopefully won't conflict with other projects. If possible, a #define is replaced with an inline function, constexpr variable, or using typename statement. If a #define is absolutely necessary, add ensure prefix of MATX_

@tmartin-gh tmartin-gh changed the title Misc Cleanup Draft: Misc Cleanup Dec 18, 2024
@cliffburdick
Copy link
Collaborator

/build

@tmartin-gh tmartin-gh changed the title Draft: Misc Cleanup Misc Cleanup Dec 18, 2024
@tmartin-gh
Copy link
Collaborator Author

/build

@tmartin-gh
Copy link
Collaborator Author

/build

@tmartin-gh
Copy link
Collaborator Author

/build

@tmartin-gh
Copy link
Collaborator Author

/build

1 similar comment
@tmartin-gh
Copy link
Collaborator Author

/build

@coveralls
Copy link

Coverage Status

coverage: 93.233% (+0.1%) from 93.135%
when pulling 6b6f641 on tmartin-gh:tm/various_cleanup
into b1a02f1 on NVIDIA:main.

@tmartin-gh tmartin-gh merged commit 1bfe456 into NVIDIA:main Dec 20, 2024
1 check passed
@tmartin-gh
Copy link
Collaborator Author

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants