Do not create CUDA events in ephemeral executors (#889)

* Do not create CUDA events in ephemeral executors

Author: cliffburdick

include/matx/executors/cuda.h

@@ -53,24 +53,31 @@ namespace matx
        * @brief Construct a new cudaExecutor with a stream
        * 
        * @param stream CUDA stream
+       * @param profiling Whether to enable profiling
        */
-      cudaExecutor(cudaStream_t stream) : stream_(stream) {
-        MATX_CUDA_CHECK(cudaEventCreate(&start_));
-        MATX_CUDA_CHECK(cudaEventCreate(&stop_));
+      cudaExecutor(cudaStream_t stream, bool profiling = true) : stream_(stream), profiling_(profiling) {
+        if (profiling_) {
+          MATX_CUDA_CHECK(cudaEventCreate(&start_));
+          MATX_CUDA_CHECK(cudaEventCreate(&stop_));
+        }
       }
 
-      cudaExecutor(int stream) : stream_(reinterpret_cast<cudaStream_t>(stream)) {
-        MATX_CUDA_CHECK(cudaEventCreate(&start_));
-        MATX_CUDA_CHECK(cudaEventCreate(&stop_));
+      cudaExecutor(int stream, bool profiling = true) : stream_(reinterpret_cast<cudaStream_t>(stream)), profiling_(profiling) {
+        if (profiling_) {
+          MATX_CUDA_CHECK(cudaEventCreate(&start_));
+          MATX_CUDA_CHECK(cudaEventCreate(&stop_));
+        }
       }
 
       /**
        * @brief Construct a new cudaExecutor object using the default stream
        * 
        */
-      cudaExecutor() : stream_(0) {
-        MATX_CUDA_CHECK(cudaEventCreate(&start_));
-        MATX_CUDA_CHECK(cudaEventCreate(&stop_));
+      cudaExecutor() : stream_(0), profiling_(true) {
+        if (profiling_) {
+          MATX_CUDA_CHECK(cudaEventCreate(&start_));
+          MATX_CUDA_CHECK(cudaEventCreate(&stop_));
+        }
       }
 
       /**
@@ -99,6 +106,7 @@ namespace matx
        * This will block until the event is synchronized
        */
       float get_time_ms() {
+        MATX_ASSERT_STR(profiling_, matxInvalidParameter, "Profiling not enabled when using get_time_ms()");
         float time;
         cudaEventSynchronize(stop_);
         cudaEventElapsedTime(&time, start_, stop_);
@@ -169,6 +177,7 @@ namespace matx
         }
 
     private:
+      bool profiling_;
       cudaStream_t stream_;
       cudaEvent_t start_;
       cudaEvent_t stop_;

include/matx/operators/base_operator.h

@@ -109,7 +109,7 @@ namespace matx
         __MATX_INLINE__ void run(cudaStream_t stream = 0)
         {
           MATX_NVTX_START(detail::get_type_str(*static_cast<T *>(this)), matx::MATX_NVTX_LOG_API)
-          run(cudaExecutor{stream});
+          run(cudaExecutor{stream, false});
         }
 
         /**
@@ -122,7 +122,7 @@ namespace matx
         {
           MATX_NVTX_START(static_cast<T *>(this)->str(), matx::MATX_NVTX_LOG_API)
 
-          run(cudaExecutor{stream});
+          run(cudaExecutor{stream, false});
           cudaEventRecord(ev, stream);
         }