Update external NRD module SHA to incorporate needed fetchcontent change #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem is a little involved as it spans three repos through submodules of submodules.
At the SHA specified in RTXPT, NRD synchs ShaderMake at a specific SHA with a shallow git depth: https://github.com/NVIDIA-RTX/NRD/blob/b233cc3ec5b1db2763e45fd18c9bb19793016355/CMakeLists.txt#L104-L105
As a result, the ShaderMake submodule is only synched with a history of 1 commit, the latest. A change was made to ShaderMake since the specified SHA tag was the latest, so it fails to find it in the history of one commit and cmake configuration fails. NRD fixed this problem by synching ShaderMake to "main" instead of that commit: NVIDIA-RTX/NRD@0479f55
If RTXPT synchs NRD Submodule to 0479f55a70d7cac341fb619ba9f0ca43deb278bb, it will benefit from that change and no longer break whenever ShaderMake gets an update.