Skip to content

Commit 6019919

Browse files
committed
Adjust tests
Signed-off-by: Wojciech Prazuch <[email protected]>
1 parent 924551f commit 6019919

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

packages/nemo-evaluator-launcher/src/nemo_evaluator_launcher/executors/slurm/executor.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -736,7 +736,6 @@ def _open_master_connection(
736736
suffix: str = "",
737737
) -> str | None:
738738
ssh_command = f"ssh -MNf -S {socket} {username}{suffix}@{hostname}"
739-
print(f"SSH Command to be executed: {ssh_command}")
740739
completed_process = subprocess.run(
741740
args=shlex.split(ssh_command), capture_output=True
742741
)

packages/nemo-evaluator-launcher/tests/unit_tests/test_slurm_executor.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1778,7 +1778,7 @@ def test_read_autoresumed_slurm_job_ids(self, monkeypatch):
17781778
# Mock _read_files_from_remote to return job ID lists
17791779
monkeypatch.setattr(
17801780
"nemo_evaluator_launcher.executors.slurm.executor._read_files_from_remote",
1781-
lambda paths, user, host, sock: ["123 456 789", "111 222"],
1781+
lambda paths, user, host, sock, suffix="": ["123 456 789", "111 222"],
17821782
raising=True,
17831783
)
17841784

@@ -1841,7 +1841,7 @@ def test_get_progress_with_dataset_size(self, monkeypatch):
18411841
# Mock file reads
18421842
monkeypatch.setattr(
18431843
"nemo_evaluator_launcher.executors.slurm.executor._read_files_from_remote",
1844-
lambda paths, user, host, sock: ["100", "config: test"]
1844+
lambda paths, user, host, sock, suffix="": ["100", "config: test"]
18451845
if "progress" in str(paths[0])
18461846
else ["framework_name: test\nconfig:\n type: test"],
18471847
raising=True,
@@ -1868,7 +1868,7 @@ def test_get_progress_no_dataset_size(self, monkeypatch):
18681868
from nemo_evaluator_launcher.executors.slurm.executor import _get_progress
18691869

18701870
# Mock file reads - return progress and valid config, but no dataset size
1871-
def mock_read_files(paths, user, host, sock):
1871+
def mock_read_files(paths, user, host, sock, suffix=""):
18721872
if "progress" in str(paths[0]):
18731873
return ["150"]
18741874
else: # run_config paths
@@ -1903,7 +1903,7 @@ def test_get_progress_missing_files(self, monkeypatch):
19031903
# Mock file reads to return empty strings (files not found)
19041904
monkeypatch.setattr(
19051905
"nemo_evaluator_launcher.executors.slurm.executor._read_files_from_remote",
1906-
lambda paths, user, host, sock: [""],
1906+
lambda paths, user, host, sock, suffix="": [""],
19071907
raising=True,
19081908
)
19091909

0 commit comments

Comments
 (0)