Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports are listed incorrectly #3

Open
veloman-yunkan opened this issue Aug 28, 2018 · 1 comment
Open

Imports are listed incorrectly #3

veloman-yunkan opened this issue Aug 28, 2018 · 1 comment

Comments

@veloman-yunkan
Copy link
Contributor

If the import module as name construct is used then it is name that is added to imports rather than module. I am definite that this must be fixed. Besides, in case of the from module import names statement names are added to imports as is. For example from sys import * will result in the * entry in the imports section. I propose to fix it by prepending the module name to the imported name. For example the following statement

from sklearn.model_selection import train_test_split

must be registered in the imports section as sklearn.model_selection.train_test_split (whereas now it is registered as train_test_split).

@veloman-yunkan
Copy link
Contributor Author

veloman-yunkan commented Aug 28, 2018

The fix of this issue is available in PR#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant