-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenStudio gbXML ReverseTranslator crash on file from ArchiCad/StruSoft #5234
Labels
Triage
Issue needs to be assessed and labeled, further information on reported might be needed
Milestone
Comments
openstudio -e "rt = OpenStudio::GbXML::GbXMLReverseTranslator.new; rt.loadModel('broken_date.xml')" It does say
|
jmarrec
added a commit
that referenced
this issue
Nov 13, 2024
jmarrec
added a commit
that referenced
this issue
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Triage
Issue needs to be assessed and labeled, further information on reported might be needed
Issue overview
User reported crash of OpenStudio Application when importing gbXML file from ArchiCad/StruSoft. File is attached to original issue openstudiocoalition/OpenStudioApplication#726
Current Behavior
The date format in the gbXML file may be invalid according to the schema. This generates an assertion/crash in the gbXML
ReverseTranslator::translateSchedule
.Expected Behavior
It would be better if the ReverseTranslator skipped invalid elements rather than crashing.
Steps to Reproduce
Use ReverseTranslator to convert the gbXML file https://github.com/user-attachments/files/16567495/M-K.OS.test.file.xml.zip to OpenStudio
Possible Solution
Skip importing invalid elements rather than crash or provide alternate method to handle invalid elements.
Details
Environment
Some additional details about your environment for this issue (if relevant):
Context
The text was updated successfully, but these errors were encountered: