Rename "Gulf of Mexico" to "Gulf of America" #3326
Comments
|
Instances of "Gulf of Mexico" in the GFS system (workflow and subcomponents): workflow: ufs-weather-model: verif-global: |
|
Already update in EMC_verif-global (NOAA-EMC/EMC_verif-global@132c761) |
Great, thanks for the update @malloryprow ! We have been using the |
|
Is this issue for GFSv16 or the develop branch ? |
Both but the ops packages first. |
I have made tag verif_global_v2.10.4 that has this change. |
Great, thanks @malloryprow ! |
|
@KateFriedman-NOAA - we're also going to need a fix file update for waves for v16 operations. Please let me know how you want me to pass that info to you. For code updates, we merged the 16.4 update to the WW3 production branch. Should I just add on top of that? or How should we handle that? |
Provide me the updated fix file on WCOSS2 and I'll pull it into a new fix set for ops.
I'm guessing this rename update will go into ops before v16.4 so we'll need a tag without the v16.4 WW3 updates in WW3 and ufs-weather-model. Either make branches before those updates went in and tag from that or undo the WW3 updates, make the rename updates, tag it, and then redo the WW3 updates and tag that. Either way, the rename update will need to be included in the tag with the WW3 updates so the 2nd option might be best but more work. :-/ |
|
Note that parm/product/bufr_stalist.meteo.gfs may also need to be modified. |
|
New wave_fix files for GFSv16 can be found here: |
Thanks @EricSinsky-NOAA ! I didn't search for the uppercase instance...I now see what you are referencing: I've add those references to my list above. Thanks! |
|
For ufs-weather-model changes related to WW3:
I have requested a new 16.4 GFS UFS-weather-model tag here: ufs-community/ufs-weather-model#2603 Updates in develop for a few wave related comments have been added to an open PR. It will take a little bit for the WW3 changes to get into ufs-weather-model for develop, but they are coming. |
|
New 16.4 tag has been created @KateFriedman-NOAA |
Excellent, thanks @JessicaMeixner-NOAA ! |
Thanks @JessicaMeixner-NOAA ! I have copied those three updated wave buoy fix files into the new gfsv16.4.0 set on both sides of WCOSS2: We'll need to update https://github.com/NOAA-EMC/global-workflow/blob/release/gfs.v16.4/sorc/link_fv3gfs.sh#L38 I'll open a PR to get that update in. |
|
Thank you @KateFriedman-NOAA - Please let me know if there's anything else I can do to help. |
New set includes updated wave buoy fix files for Gulf Of Mexico name change Refs NOAA-EMC#3326 Refs NOAA-EMC#2987
@JessicaMeixner-NOAA please review PR #3330 and we'll wrap up that update. Thanks! |
Update the `FIX_DIR` for WCOSS2 to use the new `fix_nco_gfsv16.4.0` set. For completeness, also update the Hera and Orion `FIX_DIR` path, in case we also push that fix set to those platforms (note however, we are no longer supporting non-WCOSS2 platforms for GFSv16). The new set includes updated wave buoy fix files for Gulf Of Mexico name change. Additionally, update "Mexico" to "America" in the `parm/parm_wave/bull_awips_gfswave` wave parm file. Refs #3326 Refs #2987
# Description This PR updates the wave fix which was unintentionally left out of PR #3190 Additionally, this updates what ICs the highres ci tests are pointing to (IC update issues: #3287 #3288) Resolves #3260 Refs #3326 - small changes in comments Additionally, some smaller bug fixes and changes were made: * Removes logic that tries to copy files to fix directory in ush/wave_grid_interp_sbs.sh -- Fixes #3162 * Adds MPI variables that were found needed when investigating the HR4 hang ufs-community/ufs-weather-model#2486 -- Fixes #3259 * Changes the log file output directory corresponding to an update requested by NCO in v16.3.22 in scripts/exgfs_wave_post_pnt.sh * Through debugging HR5 (#3260) it was noticed the wave ICs were not used. While there is a code change required (NOAA-EMC/WW3#1359), this PR fixes the scripting level issues & updates UFS to fix WW3 code issues. * Removes COMOUT_WAVE_PREP from wave post job that did not need it, plus ensured temporary files were not copied back to COM and then over-written (NCO bug) --- Fixes #297 * Updates ufs-weather-model hash. Details in table below Notes on ufs-weather-model updates: | Commit date | Commit hash/ PR | Notes for g-w changes | Baseline Changes | | :------------- | :------------- | :------------- | :------------- | | Jan 7, 2025 | ufs-community/ufs-weather-model@5324d64 ufs-community/ufs-weather-model#2531 | n/a | changes in regional tests, no global changes | | Jan 13, 2025 | ufs-community/ufs-weather-model@c7412fa | n/a | changes in some global coupled tests | | Jan 17, 2025 | ufs-community/ufs-weather-model@3a5e52e | n/a | no changes | | Jan 21, 2025 | ufs-community/ufs-weather-model@33cde4b | extra variable needed for waves | no changes | | Jan 22, 2025 | ufs-community/ufs-weather-model@b9d2bec | n/a | no changes | Jan 28, 2025 | ufs-community/ufs-weather-model@0682f90 | n/a | | Feb 3, 2025 | ufs-community/ufs-weather-model@a498735 | add fv3atm_output_dir to model_configure | answers change | | Feb 5, 2025 | ufs-community/ufs-weather-model@ee3d52d | changes in this PR for initialization for wave fixes | if using WW3 binary restart, answers will change |
What new functionality do you need?
The "Gulf of Mexico" is being renamed to the "Gulf of America". All references to the "Gulf of Mexico" need to be updated.
Will update ops GFSv16.3 first and then dev GFSv17.
What are the requirements for the new functionality?
Name updating.
Acceptance Criteria
All references to "Gulf of Mexico" are removed.
Suggest a solution (optional)
No response
The text was updated successfully, but these errors were encountered: