-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NCO Bug] Display clear warning when missing snogrb file #2500
Comments
@GeorgeGayno-NOAA The global-workflow scripts that handle the snogrb file currently only do the following if it doesn't exist:
If |
@KateFriedman-NOAA - I am trying to understand what that logic is doing. For the GDAS cycle there are two snow files created - t1534.3072.1536 and t574.1152.576. In this case, if the JCAP_CASE=1534/LONB_CASE=3072/LATB_CASE=1536, then the backup file is the same as the missing file? Both snow resolutions are created at the same time. So if one is old, the other should also be old. I might want to see how you run this script in the workflow. |
@GeorgeGayno-NOAA Yeah I was wondering about that as well. I don't see when we wouldn't use the higher res version anyway. It seems like it should look for that higher res file and then look back a cycle if not found. I'm also now wondering if this will work with C1152. I am running the global-workflow |
@GeorgeGayno-NOAA Please see the following logs on Hera: /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS_test/COMROOT/C96C48_hybatmDA/logs/2021122100/enkfgdas_esfc.log |
OK. I think I understand how the script works. If I look through the "./obs" directories, I only see one snow file - a "t1534.3072.1536" version. Since you run the workflow at many different resolutions, the script looks for a snow file with a comparable resolution. If it does not find one, it defaults to the t1534 version. For example, in the gdas_sfcanl.log file, it looks for a "gdas.t00z.snogrb_t190.384.192" file. It does not find it because we don't create that resolution. So, the t1534 version is used. So, I would not consider this a problem. I would not output a warning message because the SPA should not be investigating why there is no t190 file. Maybe some comments should be added to the script to assist him. Now if the t1534 files are missing, then there is a problem. One other thing, in the enkfgdas_esfc.log file, it looks for a "gdas.t00z.snogrb_t-2.0.0" file. What does "t-2.0.0" mean? |
I looked through the log and job scripts and see that the "t-2.0.0" comes from how the FNSNOA filename is built:
For the enkf_sfc job the
While investigating why
...but should be:
This looks like a bug that was hidden because the job found the backup file for
Agreed, language should be added and can be included in a PR into
Feel free to suggest alterations to the above ^ |
@KateFriedman-NOAA - how will the SPAs interpret the word "WARNING"? Will they be compelled to investigate the 'missing' snow file? How about a simple print such as |
@GeorgeGayno-NOAA Good point. I spoke with my fellow g-w CMs and we want to use the word "INFO" instead of "WARNING". With that and your suggestion, my suggestion would be:
Thoughts? |
Looks good. |
I modified it a bit more so the INFO message is always present and the log states which snow file will be used regardless of which one. Also added a comment about the file existence check:
Will be making the same update to |
@GeorgeGayno-NOAA What kind of messaging would you like if the T1534 snogrb file is missing? Here is the snogrb section of
Thoughts? |
- Add INFO echo to state which snogrb file will be used in log - Also fix bug with res setting in exgdas_enkf_sfc.sh Resolves bugzilla 1373 Refs NOAA-EMC#2500
- Add "FATAL ERROR" message if either snogrb file is missing. - Update COMIN/COMOUT variable settings (needed) Refs NOAA-EMC#2500
I would add the "echo INFO" line as an 'else' block. i.e., if [[ ! -f $FNSNOG ]]; then |
@GeorgeGayno-NOAA I like that suggestion, I will make that change. I am going to run a test that invokes the impacted jobs and then open a PR to make the changes in |
Combine the INFO and FATAL ERROR messaging for snogrb files into the same if-block. Refs NOAA-EMC#2500
Ran the C96_atm3DVar CI test on Hercules. Updates performed as expected:
|
What is wrong?
Bugzilla 1373
From bugzilla text from SPA Carlos Diaz:
What should have happened?
An alert should have been printed when snogrb used is old.
Steps to reproduce
Simulate no snogrb for current cycle and make system use older one.
Bugzilla issue
1373
Additional information
Reply from @RussTreadon-NOAA in bugzilla:
Do you have a proposed solution?
No response
The text was updated successfully, but these errors were encountered: