Logical checks should be in if blocks

[DavidHuber-NOAA]

What is wrong?

There are several places in the env/* files and possibly elsewhere that have half-logical statements. For example,

global-workflow/env/HERA.env

Line 277 in 3d6c13e

[[ ${NTHREADS_GEMPAK} -gt ${max_threads_per_task} ]] && export NTHREADS_GEMPAK=${max_threads_per_task}

If the logical returns False, then this will cause a failure if set -e is enabled as it return a non-zero status.

What should have happened?

These logical checks should be replaced with if blocks or have || true appended to them.

What machines are impacted?

All or N/A

What global-workflow hash are you using?

3d6c13e

Steps to reproduce

Run a gempak job on Hera.

Additional information

Reported by @AntonMFernando-NOAA.

Do you have a proposed solution?

For the case above, this line should be either

[[ ${NTHREADS_GEMPAK} -gt ${max_threads_per_task} ]] && export NTHREADS_GEMPAK=${max_threads_per_task} || true

expanded to

   if  [[ ${NTHREADS_GEMPAK} -gt ${max_threads_per_task} ]]; then
      export NTHREADS_GEMPAK=${max_threads_per_task}
   fi

All such examples should be addressed in the code.

[WalterKolczynski-NOAA]

Personally, I'd prefer removing all the short-circuits and only use if/else, even though it is more verbose. See also https://mywiki.wooledge.org/BashPitfalls#cmd1_.26.26_cmd2_.7C.7C_cmd3

[DavidHuber-NOAA]

Updated the description and title to reflect that.