Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error/warning message handling in RTOFS model (bugzilla #1131) #10

Open
DanIredell-NOAA opened this issue Mar 15, 2022 · 2 comments

Comments

@DanIredell-NOAA
Copy link
Contributor

http://www2.spa.ncep.noaa.gov/bugzilla/show_bug.cgi?id=1131

Improve the error/warning message handling in RTOFS model at next upgrade.

The fatal errors prefaced with ‘FATAL ERROR’ and non-fatal/warning errors prefaced with ‘WARNING’, please refer to https://www.nco.ncep.noaa.gov/idsb/implementation_standards/Implementation%20Standards%20v10.2.pdf? , page 11, section "Descriptive error messages".

@DanIredell-NOAA
Copy link
Contributor Author

Adding FATAL ERROR to all messages that will cause the simulation to stop.
Adding WARNING to non-failure messages.

@DanIredell-NOAA
Copy link
Contributor Author

NCO:
This issue has been fixed in the scripts below -

  • ush/rtofs_atmforcing_correct.sh, rtofs_atmforcing.sh, rtofs_prestaging.sh, rtofs_atmforcing_stage.sh, rtofs_ncoda_amsr_qc.sh, rtofs_ncoda_goes_qc.sh, rtofs_ncoda_himawari_qc.sh, rtofs_ncoda_ice_qc.sh, rtofs_ncoda_jpss_qc.sh, rtofs_ncoda_metop_qc.sh, rtofs_ncoda_npp_qc.sh, rtofs_ncoda_ssh_qc.sh, rtofs_ncoda_sss_qc.sh, rtofs_ncoda_vel_qc.sh, rtofs_prestaging.sh, rtofs_runstaging.sh,
  • scripts/exrtofs_glo_analysis.sh, exrtofs_glo_forecast.sh, exrtofs_glo_incup.sh, exrtofs_glo_ncoda_glbl_var.sh, exrtofs_glo_ncoda_hycom_var.sh, exrtofs_glo_ncoda_polar_var.sh, exrtofs_glo_ncoda_qc.sh.

However, the following scripts can be improved to add ‘FATAL ERROR’ for fatal errors and ‘WARNING’ for non-fatal/warning errors in the messages -

  • scripts/exrtofs_glo_grib2_post.sh: echo "Missing file $fn, will not be able to run" >> ${RUN}_${modID}.t${mycyc}z.nav.log
  • scripts/exrtofs_glo_gzip.sh: echo " $tgzfile was not produced, exiting now."
  • scripts/exrtofs_glo_gzip.sh: echo " $file missing, exiting now."
  • scripts/exrtofs_glo_gzip.sh: echo " $tgzfile was not produced, exiting now."
  • scripts/exrtofs_glo_gzip.sh: echo " $tgzfile was not produced, exiting now."
  • scripts/exrtofs_glo_gzip.sh: echo "Cycle not recognized RTOFS GZIP JOB, NO GZIPPED FILES ALERTED"
  • scripts/exrtofs_glo_post_2.sh: echo "Missing file $fn, will not be able to run" >> ${RUN}_${modID}.t${mycyc}z.nav.log
  • scripts/exrtofs_glo_post.sh: echo Post timed out, arfile_tplate not available after $icnt_max iterations.
  • scripts/exrtofs_glo_post.sh: echo Missing file $fn, will not be able to run
  • ush/rtofs_atmforcing_getges.sh: echo getges.sh: filetype $typef or resolution $resol not recognized >&2
  • ush/rtofs_ncoda_amsr_qc.sh: echo "AMSR.obs_control file will not be updated"
  • ush/rtofs_ncoda_goes_qc.sh: echo "GOES.obs_control file will not be updated"
  • ush/rtofs_ncoda_himawari_qc.sh: echo "HIMAWARI.obs_control file will not be updated"
  • ush/rtofs_ncoda_ice_qc.sh: echo "SSMI.obs_control file will not be updated"
  • ush/rtofs_ncoda_ice_qc.sh: echo "AMSR_ICE.obs_control file will not be updated"
  • ush/rtofs_ncoda_jpss_qc.sh: echo "JPSS_VIIRS.obs_control file will not be updated"
  • ush/rtofs_ncoda_metop_qc.sh: echo "METOP.obs_control file will not be updated"
  • ush/rtofs_ncoda_npp_qc.sh: echo "NPP_VIIRS.obs_control file will not be updated"
  • ush/rtofs_ncoda_sss_qc.sh: echo "SSS.obs_control file will not be updated"

Please continue to improve the RTOFS scripts in the coming upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant