Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons are missing data attribute #218

Closed
edwardhorsford opened this issue May 3, 2024 · 1 comment
Closed

Buttons are missing data attribute #218

edwardhorsford opened this issue May 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@edwardhorsford
Copy link
Contributor

The buttons in the NHS design system include a data attribute that seems to be missing from the buttons shown in the storybook examples.

Example from the design system:

<button class="nhsuk-button" data-module="nhsuk-button" type="submit">
  Save and continue
</button>

Example from storybook:

<button class="nhsuk-button" aria-disabled="false" type="submit">Primary</button>
@edwardhorsford edwardhorsford mentioned this issue May 10, 2024
Closed
@edwardhorsford edwardhorsford added the bug Something isn't working label May 10, 2024
edwardhorsford added a commit that referenced this issue May 21, 2024
@edwardhorsford
Add missing data module to buttons - Fixes issue #218
af6227b
@edwardhorsford edwardhorsford mentioned this issue May 21, 2024
Closed
@Tomdango
Copy link
Collaborator

Fixed by #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@edwardhorsford @Tomdango