Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lax peerDependency range causes bugs with later releases of nhsuk-frontend #178

Open
KaiSpencer opened this issue Aug 29, 2023 · 0 comments · May be fixed by #179
Open

Lax peerDependency range causes bugs with later releases of nhsuk-frontend #178

KaiSpencer opened this issue Aug 29, 2023 · 0 comments · May be fixed by #179

Comments

@KaiSpencer
Copy link
Contributor

We have a peerDependency on the nhsuk-frontend of >=4.0.0, we currently have implementation of upto v4.x.x of the nhsuk-frontend and hence installing later versions breaks some components which have css removed (e.g. care-card is moved to a variant of card and the care-card classes are removed)

We should specify a peerDependency range which is inclusive of the current version on the nhsuk-frontend that we have implemented in the library.

Repro:

  1. Init react app
  2. Install nhsuk-frontend latest
  3. Install nhsuk-react-components
  4. Mount CareCard component
  5. No styling applied as css removed in nhsuk-frontend v6
@KaiSpencer KaiSpencer changed the title Lax peedDependency range causes bugs with later releases of nhsuk-frontend Lax peerDependency range causes bugs with later releases of nhsuk-frontend Aug 29, 2023
@KaiSpencer KaiSpencer linked a pull request Aug 30, 2023 that will close this issue
Open
@KaiSpencer KaiSpencer mentioned this issue Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@KaiSpencer