Skip to content

Commit a529377

Browse files
committed
Validator landing page files check
Remove the stripping of the LANDING_PAGES/THUMBNAILS prefix when we try to match which thumbnails are present We did not catch this last time because no landing page submission was tested.
1 parent efbb94b commit a529377

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

validator/validator.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -771,7 +771,7 @@ function comparing_files {
771771
all_thumbnail_files=$(for bucket in "${INBOX_BUCKETS[@]}"; do
772772
s3cmd_command ls "s3://${bucket}/${user}/${dataset}/LANDING_PAGE/THUMBNAILS/" --recursive 2>/dev/null
773773
done | awk '{print $4}' | sort -u)
774-
all_thumbnail_relative=$(echo "$all_thumbnail_files" | sed -E "s|s3://[^/]+/${user}/${dataset}/LANDING_PAGE/THUMBNAILS/||" | sed 's/\.c4gh$//' | sort -u)
774+
all_thumbnail_relative=$(echo "$all_thumbnail_files" | sed -E "s|s3://[^/]+/${user}/${dataset}/||" | sed 's/\.c4gh$//' | sort -u)
775775
count_inbox_thumbnail_files=$(echo "$all_thumbnail_relative" | sed '/^$/d' | wc -l)
776776
metadata_thumbnail_files=$(xmllint --xpath '/LANDING_PAGE_SET/LANDING_PAGE/SAMPLE_IMAGE_FILES/SAMPLE_IMAGE_FILE/@filename' xml-files/landing_page.xml | awk -F= '{print $2}' | sed 's/"//g')
777777
count_metadata_thumbnail_files=$(echo "$metadata_thumbnail_files" | wc -l)

0 commit comments

Comments
 (0)