Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify if we correctly check for null values #168

Open
gijzelaerr opened this issue Jan 14, 2022 · 0 comments
Open

Verify if we correctly check for null values #168

gijzelaerr opened this issue Jan 14, 2022 · 0 comments
Milestone
0.12

Comments

@gijzelaerr
Copy link
Collaborator

This PR changes how we check for null values using a list comprehension:

https://github.com/MonetDBSolutions/MonetDBe-Python/pull/167/files#diff-50400c771b1134baeb7e4c99cb21a03fc2dcb0e18d76e63260d88ada8ce14156R40

we need to make sure this is the fastest way to do it, maybe the older numpy method was faster.
@gijzelaerr gijzelaerr added this to the 0.12 milestone Jan 14, 2022
@gijzelaerr gijzelaerr mentioned this issue Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
1 participant
@gijzelaerr