Upgrade code shown on console

Describe the bug
When you start the latest version (on my Mac) the startup of monetdbe involves running the upgrade command. This currently leads to a large list of action results on stdout.

Expected behavior
No output from the upgrade code should be shown during startup. Only if it raises an exception.

Software versions

• OS and version: [e.g. Ubuntu 18.04]
• Python version: [e.g. 3.7]
• MonetDBe-Python version: [e.g. 0.7]

[gijzelaerr]

Do you have an example of the output? Op do 12 nov. 2020 22:24 schreef Martin Kersten <notifications@github.com>:

…

*Describe the bug* When you start the latest version (on my Mac) the startup of monetdbe involves running the upgrade command. This currently leads to a large list of action results on stdout. *Expected behavior* No output from the upgrade code should be shown during startup. Only if it raises an exception. *Software versions* - OS and version: [e.g. Ubuntu 18.04] - Python version: [e.g. 3.7] - MonetDBe-Python version: [e.g. 0.7] — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#108>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACPVJEQHIYDGKK4PYHYO3TSPQ75NANCNFSM4TTX3RVA> .

Connect to 'data/test'
Running database upgrade commands:
set schema "sys";
delete from sys.dependencies where id < 2000;
delete from sys.types where id < 2000;
insert into sys.types values (0, 'void', 'any', 0, 0, 0, 0, 2000);
....
ALTER TABLE sys.keywords SET READ WRITE;
insert into sys.keywords values ('EPOCH');
commit;
set schema "sys";

Database 'data/test' created
Welcome to mclient, the MonetDB/SQL interactive terminal (unreleased)
Type \q to quit, \? for a list of available commands
>```

    def createdb(dbname, debug=False):
        if debug:
            print(f"Connect to '{dbname}'")
        try:
            HolmesDB.connection = monetdbe.connect(dbname, autocommit=True)
            if debug:
                print(f"Database '{dbname}' created")
        except monetdbe.DatabaseError as msg:
            print('ERROR: Failed to establish database connection', msg)
            exit(-1)```

[evangelos-dimitriadis]

I can replicate the bug - strange behavior in Ubuntu too after upgrading to Oct20-SP1.
The line:
conn = monetdbe.connect(APP_DB)

will result in a series of queries:

Running database upgrade commands:
set schema "sys";
delete from sys.dependencies where id < 2000;
delete from sys.types where id < 2000;
insert into sys.types values (0, 'void', 'any', 0, 0, 0, 0, 2000);
insert into sys.types values (1, 'bat', 'table', 0, 0, 0, 1, 2000);
insert into sys.types values (2, 'ptr', 'ptr', 0, 0, 0, 1, 2000);
insert into sys.types values (3, 'bit', 'boolean', 1, 0, 2, 2, 2000);
insert into sys.types values (4, 'str', 'char', 0, 0, 0, 3, 2000);
insert into sys.types values (5, 'str', 'varchar', 0, 0, 0, 4, 2000);
insert into sys.types values (6, 'str', 'clob', 0, 0, 0, 4, 2000);
...

I tried to use the logging flag to send that output to a temp file, which will raise a "raise NotImplemented # todo".

[gijzelaerr]

sorry, what raises the NotImplemented exception precisly? Just configuring the logger should work fine.

[evangelos-dimitriadis]

I have tried something similar to this:

conn = monetdbe.connect(APP_DB, logging=Path('/tmp/log'))