ci(release): 每次构建都上传打包产物

Author: PencilMario

.github/workflows/release.yml

@@ -71,14 +71,12 @@ jobs:
           echo "create_release=true" >> $GITHUB_OUTPUT
         fi
 
-    - name: Create release version file
-      if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'
-      run: |
+    - name: Create release version file
+      run: |
         echo "${{ steps.get_version.outputs.version }}" > game/python-packages/maica_release_version
 
-    - name: Download Ignore Translation Conflicts dependency
-      if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'
-      run: |
+    - name: Download Ignore Translation Conflicts dependency
+      run: |
         dependency_tmp_dir="$(mktemp -d)"
         dependency_archive="$dependency_tmp_dir/dependency.zip"
         dependency_extracted="$dependency_tmp_dir/extracted"
@@ -103,7 +101,6 @@ jobs:
         cp -R "$dependency_source" game/Submods/
 
     - name: Download CertifiFixer dependency
-      if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'
       env:
         GH_TOKEN: ${{ github.token }}
       run: |
@@ -131,30 +128,36 @@ jobs:
         cp -R "$dependency_source" game/Submods/
 
     - name: Copy documentation into submod package
-      if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'
       run: |
         cp README.md README_EN.md LICENSE game/Submods/MAICA_ChatSubmod/
 
     - name: Create zip package
-      if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'
       run: |
         zip -r MAICA_ChatSubmod-${{ steps.get_version.outputs.version }}.zip \
           characters \
           game \
           lib
-
-    - name: Generate Release Notes
-      id: generate_release_notes
-      if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'
-      run: |
+
+    - name: Generate Release Notes
+      id: generate_release_notes
+      run: |
         # Extract release notes from the latest commit message or a predefined template
         release_notes=$(git log -1 --pretty=%B)
         # Convert release notes to GitHub Flavored Markdown
         echo "$release_notes" | sed 's/^/- /' > release_notes.md
         # Prepend version information
         echo "## MAICA ChatSubmod ${{ steps.get_version.outputs.version }}" | cat - release_notes.md > temp && mv temp release_notes.md
-        echo "RELEASE_NOTES_PATH=release_notes.md" >> $GITHUB_OUTPUT
-
+        echo "RELEASE_NOTES_PATH=release_notes.md" >> $GITHUB_OUTPUT
+
+    - name: Upload artifact
+      uses: actions/upload-artifact@v4
+      with:
+        name: release-files
+        path: |
+          MAICA_ChatSubmod-${{ steps.get_version.outputs.version }}.zip
+          release_notes.md
+        retention-days: 30
+
     - name: Create Release
       if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'
       uses: softprops/action-gh-release@v2
@@ -171,17 +174,7 @@ jobs:
       run: |
         echo "Release ${{ steps.get_version.outputs.version }} already exists. Skipping release creation."
 
-    - name: Skip development build
-      if: steps.get_version.outputs.is_development == 'true'
-      run: |
+    - name: Skip development build
+      if: steps.get_version.outputs.is_development == 'true'
+      run: |
         echo "Development build ${{ steps.get_version.outputs.version }} is not eligible for release."
-
-    - name: Upload artifact
-      if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'
-      uses: actions/upload-artifact@v4
-      with:
-        name: release-files
-        path: |
-          MAICA_ChatSubmod-${{ steps.get_version.outputs.version }}.zip
-          release_notes.md
-        retention-days: 30

tests/test_certifi_fixer_dependency.py

@@ -26,7 +26,7 @@ def test_release_stages_certifi_fixer_before_creating_package():
     assert DEPENDENCY_REPO in dependency_block
     assert 'gh release download' in dependency_block
     assert '--pattern "CertifiFixer-*.zip"' in dependency_block
-    assert "if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'" in dependency_block
+    assert "if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'" not in dependency_block
     assert "unzip -q" in dependency_block
     assert "game/Submods/CertifiFixer" in dependency_block
     for filename in ("certifi_fixer.rpy", "core.py", "__init__.py", "cacert.pem"):

tests/test_ignore_translation_conflicts_dependency.py

@@ -23,7 +23,7 @@ def test_release_stages_dependency_before_creating_package():
     dependency_block = workflow[download_step:package_step]
 
     assert DEPENDENCY_URL in dependency_block
-    assert "if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'" in dependency_block
+    assert "if: steps.get_version.outputs.is_development == 'false' && steps.check_release.outputs.create_release == 'true'" not in dependency_block
     assert "curl" in dependency_block
     assert "--fail" in dependency_block
     assert "--location" in dependency_block

tests/test_release_artifact.py

@@ -0,0 +1,30 @@
+from pathlib import Path
+
+
+WORKFLOW = (
+    Path(__file__).resolve().parents[1] / ".github" / "workflows" / "release.yml"
+)
+
+
+def test_zip_and_artifact_are_created_even_when_release_is_skipped():
+    workflow = WORKFLOW.read_text(encoding="utf-8")
+    package_step = workflow.index("- name: Create zip package")
+    artifact_step = workflow.index("- name: Upload artifact")
+    release_step = workflow.index("- name: Create Release")
+
+    assert package_step < artifact_step < release_step
+    for step_name in (
+        "Create release version file",
+        "Download Ignore Translation Conflicts dependency",
+        "Download CertifiFixer dependency",
+        "Copy documentation into submod package",
+        "Create zip package",
+        "Generate Release Notes",
+        "Upload artifact",
+    ):
+        block = workflow.split("- name: " + step_name, 1)[1].split("\n    - name:", 1)[0]
+        assert "\n      if:" not in block
+
+    artifact = workflow[artifact_step:release_step]
+    assert "MAICA_ChatSubmod-${{ steps.get_version.outputs.version }}.zip" in artifact
+    assert "release_notes.md" in artifact