-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any of of 'requirejs' breaks build. #34
Comments
Same issue here. |
@cibulka You can see the workaround we ended up using here https://github.com/hatchddigital/empty-coop/blob/master/gulp/tasks/scripts.js#L72 Basically using exec to invoke the external requirejs builder; but probably a better long term solution is just to stop using requirejs. :P Anyhow, hope that helps. |
@shadowmint Thank you! After the pain I had with the setup of my Requirejs workflow, I think I will have to use it for a while :), so for now, I settled with using Modernizr directly from command line. Thanks for the info, I'm definitely trying the workaround later! |
For now, I've resorted to use https://github.com/shinnn/modernizr-stream, so I can use Modernizr's command line along with my Gulp workflow. Maybe someone finds that useful ... |
If any other module uses the
requirejs
api aftergulp-modernizr
is imported, eg:Or, for example, using https://github.com/jlouns/gulp-requirejs-optimize ...
Then the build will fail like this:
This is because https://github.com/Modernizr/Modernizr/blob/master/lib/build.js#L154 fails to resolve anything, presumably because
requirejs
is initialized when thegulp-modernizr
package is initially imported, and then somehow screwed up when something uses it.I don't have any solution to this other than, 'Don't use anything that uses requirejs in your build', but I thought I'd report this here (even though technically the problem is in modernizr, not gulp-modernizr), so that frustrated folks could find it easily.
The text was updated successfully, but these errors were encountered: