Skip to content

Commit ceb86d6

Browse files
authored
Merge pull request #137 from ModelOriented/ggplot4-is-here
Fix compatibility issue with ggplot 4.0 and add reverse dependency check
2 parents a0bf483 + f166f6e commit ceb86d6

File tree

8 files changed

+31
-332
lines changed

8 files changed

+31
-332
lines changed

.Rbuildignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@
1111
^backlog$
1212
^CRAN-SUBMISSION$
1313
^pkgdown$
14+
^revdep$

NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# hstats 1.2.2
22

3+
## Bug fixes
4+
5+
- Compatibility warning with ggplot v4.0.
6+
37
## Documentation
48

59
- Changed Tidymodels example to probabilistic multiclass, see discussion in [#129](https://github.com/ModelOriented/hstats/issues/129).

R/hstats.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ plot.hstats <- function(
481481
dat <- barplot_reverter(dat)
482482

483483
p <- ggplot2::ggplot(dat, ggplot2::aes(x = value_, y = variable_)) +
484-
ggplot2::ylab(ggplot2::element_blank()) +
484+
ggplot2::ylab(NULL) +
485485
ggplot2::xlab(su$h2$description) # Generic enough?
486486

487487
if (x[["K"]] == 1L) {

R/utils_statistics.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ plot.hstats_matrix <- function(
350350
}
351351

352352
p <- ggplot2::ggplot(df, ggplot2::aes(x = value_, y = variable_)) +
353-
ggplot2::ylab(ggplot2::element_blank()) +
353+
ggplot2::ylab(NULL) +
354354
ggplot2::xlab(x[["description"]])
355355

356356
K <- ncol(M)

backlog/calibration.R

Lines changed: 0 additions & 327 deletions
This file was deleted.

cran-comments.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
# Re-submission: hstats 1.2.1
1+
# Re-submission: hstats 1.2.2
22

3-
This is a small update, fixing a wrong ORCID.
3+
Ciao CRAN team
4+
5+
This is a small update, mainly dealing with an incompatibility warning of ggplot 4.0.
46

57
## Local checks
68

@@ -9,3 +11,8 @@ This is a small update, fixing a wrong ORCID.
911
## Winbuilder
1012

1113
Status: OK
14+
15+
## Reverse dependencies (1)
16+
17+
mrIML 2.1.0 ?????? E: 0 | W: 0 | N: 0
18+
OK: 1

0 commit comments

Comments
 (0)