Address review

Author: daxpedda

non-msrv-tests/tests/ui/item.rs

@@ -41,4 +41,8 @@ struct MissingCommaBetweenGenerics<T, U, V>(T, PhantomData<(U, V)>);
 #[derive_where("Clone")]
 struct InvalidTrait<T>(PhantomData<T>);
 
+#[derive_where(Clone)]
+#[derive_where::derive_where(Copy)]
+struct QualifiedNotFirstMacro<T>(PhantomData<T>);
+
 fn main() {}

non-msrv-tests/tests/ui/item.stderr

@@ -14,11 +14,11 @@ error: empty `derive_where` found
   |
   = note: this error originates in the attribute macro `derive_where` (in Nightly builds, run with -Z macro-backtrace for more info)
 
-error: the `crate` option has to be defined in it's own `#[derive_where(..)` attribute
+error: unexpected option syntax
   --> tests/ui/item.rs:11:16
    |
 11 | #[derive_where(crate(derive_where_))]
-   |                ^^^^^
+   |                ^^^^^^^^^^^^^^^^^^^^
 
 error: expected path, expected identifier
   --> tests/ui/item.rs:14:24
@@ -79,3 +79,11 @@ error: unexpected option syntax
    |
 41 | #[derive_where("Clone")]
    |                ^^^^^^^
+
+error: `#[derive_where(..)` was already applied to this item before, this occurs when using a qualified path for any `#[derive_where(..)`s except the first
+  --> tests/ui/item.rs:44:1
+   |
+44 | #[derive_where(Clone)]
+   | ^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: this error originates in the attribute macro `derive_where` (in Nightly builds, run with -Z macro-backtrace for more info)

src/attr/item.rs

@@ -54,8 +54,8 @@ impl ItemAttr {
 										// Don't parse `Skip` yet, because it needs access to all
 										// `DeriveWhere`s.
 										skip_inners.push(meta);
-									} else if let Meta::NameValue(name_value) = meta {
-										if name_value.path.is_ident("crate") {
+									} else if meta.path().is_ident("crate") {
+										if let Meta::NameValue(name_value) = meta {
 											if let Lit::Str(lit_str) = &name_value.lit {
 												match lit_str.parse::<Path>() {
 													Ok(path) => {
@@ -93,7 +93,7 @@ impl ItemAttr {
 												));
 											}
 										} else {
-											return Err(Error::option_syntax(name_value.span()));
+											return Err(Error::option_syntax(meta.span()));
 										}
 									}
 									// The list can have one item but still not be the `skip_inner`