Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting button issues in gtfs.staging.org #497

Closed
emmambd opened this issue Jun 20, 2024 · 4 comments · Fixed by MobilityData/elrond.gtfs.org#85
Closed

Formatting button issues in gtfs.staging.org #497

emmambd opened this issue Jun 20, 2024 · 4 comments · Fixed by MobilityData/elrond.gtfs.org#85
Assignees
Labels
enhancement New feature or request

Comments

@emmambd
Copy link
Contributor

emmambd commented Jun 20, 2024

Feature request

Is your feature request related to a problem? Please describe.
In order to unblock #493, some formatting issues with the buttons on gtfs.staging.org need to be adjusted.

cc @eliasmbd @Sergiodero

@emmambd emmambd added the enhancement New feature or request label Jun 20, 2024
@eliasmbd
Copy link
Contributor

Here are the issues that need the formatting to be corrrected:

Buttons are not showing up as in the designer figma. i.e.:
Screenshot 2024-06-20 at 3 29 22 PM

This happens on the following pages:
https://staging.gtfs.org/getting_started/why_use_GTFS/
https://staging.gtfs.org/community/extensions/fares-v2/
https://staging.gtfs.org/community/extensions/flex/

The buttons on the cookie consent screen need to be revised:
Screenshot 2024-06-20 at 3 32 13 PM

Also, buttons using external links show up misaligned:
image

See these 2 pages:
https://staging.gtfs.org/community/extensions/fares-v2/
https://staging.gtfs.org/community/extensions/flex/

@Sergiodero
Copy link
Contributor

Thanks for this! before starting to work on this it might be good to wait for PR 84 (file restructure) to be merged. I've just approved the changes, but I'll let @fredericsimard move forward with the merge in case anything needs to be fixed. Thanks again everyone.

@emmambd
Copy link
Contributor Author

emmambd commented Jun 20, 2024

Would be good to approve PR 84 ASAP then, since @Alessandro100 only has guaranteed time for this today and tomorrow. cc @fredericsimard

@Sergiodero
Copy link
Contributor

I think I'll merge it to unblock Alessandro and let @fredericsimard step in in case there's any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants