Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex: geo_json_parsing_failed #1927

Open
emmambd opened this issue Dec 2, 2024 · 3 comments · May be fixed by #1947
Open

Flex: geo_json_parsing_failed #1927

emmambd opened this issue Dec 2, 2024 · 3 comments · May be fixed by #1947
Assignees
Labels
flex Rules and rule changes related to GTFS-Flex. new rule New rule to be added

Comments

@emmambd
Copy link
Contributor

emmambd commented Dec 2, 2024

Describe the problem

Equivalent rule of https://gtfs-validator.mobilitydata.org/rules.html#csv_parsing_failed-table

Describe the new validation rule

if geoJSON file cannot be parsed, return error.

filename | The name of the faulty file. | string
message | The detailed message describing the error, and the internal state of the parser/writer. | string

Sample GTFS datasets

Example of what this looks like for csv_parsing_failed

Severity

Error

Additional context

No response

@emmambd emmambd added flex Rules and rule changes related to GTFS-Flex. new rule New rule to be added status: Needs triage Applied to all new issues labels Dec 2, 2024
@emmambd emmambd added this to the 7.0 Validator Release milestone Dec 2, 2024
@emmambd emmambd removed the status: Needs triage Applied to all new issues label Dec 2, 2024
@davidgamez
Copy link
Member

Test use case from #1929

@qcdyx qcdyx self-assigned this Jan 22, 2025
@qcdyx
Copy link
Contributor

qcdyx commented Jan 24, 2025

Initially, I added a GeoJsonParsingFailedNotice, but later realized that the cases it covered were already addressed by MalformedJsonNotice and UnsupportedGeoJsonTypeNotice in the GeoJsonFileLoader class. As a result, I removed GeoJsonParsingFailedNotice class and added message fields to both MalformedJsonNotice and UnsupportedGeoJsonTypeNotice. @emmambd @davidgamez

@emmambd
Copy link
Contributor Author

emmambd commented Jan 24, 2025

@qcdyx This makes sense to me! Can we see screenshot examples of what this looks like?

@qcdyx qcdyx linked a pull request Jan 24, 2025 that will close this issue
5 tasks
@qcdyx qcdyx linked a pull request Jan 24, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flex Rules and rule changes related to GTFS-Flex. new rule New rule to be added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants