-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency on virtual station #719
Comments
It is a breaking change, as it will break consumers that rely on lat/lon. |
Hello Ivan, That's a good point, there is an inconsistency. Thank you for flagging. As you pointed out, the I could imagine that data consumers would find it more convenient to have the For this reason, my recommendation is to remove the part that says "the station may be defined by a point (lat/lon) and/or station_area (below)." from the Curious to hear what you and the community thinks. Thanks |
Maybe a clarification works better. Having a station_area + the centroid point of the station area (https://turfjs.org/docs/api/centroid) would be a nice to have. Without breaking the currrent spec. This will be handy to show a marker when you are a little bit zoomed out for example. An example implementation of that you can find here https://dashboarddeelmobiliteit.nl/map/beleidshubs?phase=active&gm_code=GM0014&visible=hub-active&visible=verbodsgebied-active (try to zoom in on a hub icon). |
In Where To?, we rely on |
Greetings,
I noticed what seems to be an inconsistency in the definition of station_information.json.
For the field
is_virtual_station
we have:But we also have for the field
station_area
:But it is currently not possible to set
lat/lon
to null. This mean that even if we want to define onlystation_area
, we are forced to definelat/lon
that become the significant coordinate.In my opinion, the solution is to be able to set
lat/lon
to null, because even if it possible to define a virtual station with only a single coordinate it should also be possible to defined a virtual station with only a set of coordinates.You'll also need to make sure that either
lat/lon
orstation_area
is supplied and not null.Is your potential solution a breaking change?
The text was updated successfully, but these errors were encountered: