Fix CQS signal. Id] 60881465 -- performance-unnecessary-value-param in fbcode/cachelib/common [A]

Reviewed By: haowu14

Differential Revision: D74699858

fbshipit-source-id: 2b7bd98956c1d13af18c1fe1256bb170ad0454ef

Author: generatedunixname89002005287564

cachelib/common/TestUtils.cpp

@@ -36,7 +36,7 @@ constexpr uint64_t kDefaultTimeoutSecs = 30;
  * by calling this one.
  */
 ::testing::AssertionResult eventuallyTrue(
-    std::function<::testing::AssertionResult(bool)> test,
+    const std::function<::testing::AssertionResult(bool)>& test,
     uint64_t timeoutSecs) {
   constexpr uint64_t kMicrosPerSec = 1000000;
   const uint64_t timeoutUSec = timeoutSecs * kMicrosPerSec;

cachelib/common/Utils.h

@@ -30,6 +30,7 @@
 #include <folly/logging/xlog.h>
 
 #include <numeric>
+#include <utility>
 
 namespace facebook {
 namespace cachelib {
@@ -74,14 +75,14 @@ class CounterVisitor {
   }
 
   void operator=(std::function<void(folly::StringPiece, double)> biFn) {
-    biFn_ = biFn;
+    biFn_ = std::move(biFn);
     triFn_ = nullptr;
     init();
   }
 
   void operator=(
       std::function<void(folly::StringPiece, double, CounterType)> triFn) {
-    triFn_ = triFn;
+    triFn_ = std::move(triFn);
     biFn_ = nullptr;
     init();
   }
@@ -133,10 +134,10 @@ class StatsMap {
   }
 
   // Insert a count stat
-  void insertCount(std::string key, double val) { countMap[key] = val; }
+  void insertCount(const std::string& key, double val) { countMap[key] = val; }
 
   // Insert a rate stat
-  void insertRate(std::string key, double val) { rateMap[key] = val; }
+  void insertRate(const std::string& key, double val) { rateMap[key] = val; }
 
   const std::unordered_map<std::string, double>& getCounts() const {
     return countMap;