Bulk changes from review

Author: domfournier

simpeg_drivers/electricals/base_2d.py

@@ -118,7 +118,7 @@ def selected_parts(self) -> list[int]:
                     if val in self.line_selection.value:
                         parts.append(count)
             else:
-                parts = np.arange(len(np.unique(self.line_parts)))
+                parts = np.arange(len(np.unique(self.line_parts))).tolist()
 
             self._selected_parts = parts
 

simpeg_drivers/electromagnetics/base_1d_driver.py

@@ -14,6 +14,7 @@
 import multiprocessing
 from logging import getLogger
 from pathlib import Path
+from typing import Any
 
 import numpy as np
 from discretize import TensorMesh
@@ -22,6 +23,8 @@
 from geoh5py import Workspace
 from geoh5py.shared.merging.drape_model import DrapeModelMerger
 from geoh5py.ui_json.ui_json import fetch_active_workspace
+from numpy import dtype, ndarray
+from numpy.lib._shape_base_impl import _ScalarT
 
 from simpeg_drivers.components.factories import SimulationFactory
 from simpeg_drivers.components.meshes import InversionMesh
@@ -86,7 +89,7 @@ def get_1d_mesh(self) -> TensorMesh:
         )
         return layers_mesh
 
-    def get_tiles(self) -> dict[str, list[np.ndarray]]:
+    def get_tiles(self) -> dict[None, list[list[ndarray[tuple[Any, ...]]]]]:
         n_data = self.inversion_data.mask.sum()
         indices = np.arange(n_data)
 

simpeg_drivers/electromagnetics/frequency_domain/options.py

@@ -92,7 +92,7 @@ class FDEMForwardOptions(BaseForwardOptions, BaseFDEMOptions):
     :param y_imag_channel_bool: In-line (imaginary) component of impedance channel boolean.
     :param x_real_channel_bool: Cross-line (real) component of impedance channel boolean.
     :param x_imag_channel_bool: Cross-line (imaginary) component of impedance channel
-    :param models: Specify whether the models are provided in resistivity or conductivity.
+    :param models: ConductivityModelOptions parameter.
     """
 
     name: ClassVar[str] = "Frequency Domain Electromagnetics Forward"
@@ -132,7 +132,7 @@ class FDEMInversionOptions(BaseFDEMOptions, BaseInversionOptions):
     :param x_real_uncertainty: Cross-line (real) impedance uncertainty channel.
     :param x_imag_channel: Cross-line (imaginary) impedance channel.
     :param x_imag_uncertainty: Cross-line (imaginary) impedance uncertainty channel
-    :param models: Specify whether the models are provided in resistivity or conductivity.
+    :param models: ConductivityModelOptions parameter.
     """
 
     name: ClassVar[str] = "Frequency Domain Electromagnetics Inversion"

simpeg_drivers/utils/synthetics/meshes.py

@@ -135,7 +135,7 @@ def get_octree_mesh(
         center = list(plate.origin)
         center[2] += plate.width  # Unclear why offsetted vertically
         plate = Plate(plate_options, center=center, workspace=survey.workspace)
-        mesh = OctreeDriver.refine_tree_from_surface(
+        mesh = OctreeDriver.refine_tree_from_triangulation(
             mesh, plate.surface, levels=(4,), finalize=False
         )