Batch update doesn't work with multiple threads

[matsdecker]

I have an api that bulk updates but when there are multiple requests to the api i got an error that the table already exist.

It boils down to DateTime.Now.Ticks being identical in temp table name for concurrent requests/bulk updates.

I created a custom IQueryProvider by copying SqlQueryProvider and change line 86 as below and now the same test works.

from:
var tempTableName = "temp_" + tableName + "_" + DateTime.Now.Ticks;

to:
var tempTableName = "temp_" + tableName + "_" + Guid.NewGuid().ToString("N");

[MikaelEliasson]

I see, nice catch!

[sjashari112358]

Can the GUID Change be implemented into the solution? I have seen this exception be brought up in an environment. In reference to the "table name is already in use" error.

It would be greatly appreciated.

[RubberChickenParadise]

There is one more issue with this bug as titled ("Batch update doesn't work with multiple threads"). There is a race condition in EfMappingFactory when trying to get the mapping from the cache. If 2 threads try to pull from the cache at nearly the same time before the context has been added to the cache both threads will fail to get a value from the dictionary and try to add the value. The first thread will succeed while the second will throw an ArgumentException due to a duplicate key.

#61 submitted to resolve both issues.

[RudeySH]

The fix will probably never be merged into this library, the author hasn't responded for years. I am maintaining a fork which includes this fix. See https://github.com/RudeySH/EntityFramework.Utilities