fix clippy lints

Author: LucasJavaudin

metropolis-core/src/io/csv.rs

@@ -47,7 +47,7 @@ pub fn write_csv_with_prefix<D: ToArrow<J>, const J: usize>(
     prefix: &str,
 ) -> Result<()> {
     let batches = D::to_arrow(data)?;
-    for (name, maybe_batch) in D::names().into_iter().zip(batches.into_iter()) {
+    for (name, maybe_batch) in D::names().into_iter().zip(batches) {
         if let Some(batch) = maybe_batch {
             let filename: PathBuf = [output_dir.to_str().unwrap(), &format!("{prefix}{name}.csv")]
                 .iter()

metropolis-core/src/io/parquet.rs

@@ -45,7 +45,7 @@ pub fn write_parquet_with_prefix<D: ToArrow<J>, const J: usize>(
     prefix: &str,
 ) -> Result<()> {
     let batches = D::to_arrow(data)?;
-    for (name, maybe_batch) in D::names().into_iter().zip(batches.into_iter()) {
+    for (name, maybe_batch) in D::names().into_iter().zip(batches) {
         if let Some(batch) = maybe_batch {
             let filename: PathBuf = [
                 output_dir.to_str().unwrap(),

metropolis-core/src/network/road_network/mod.rs

@@ -531,7 +531,7 @@ impl RoadEdge {
         } else if let (Some(times), Some(flows)) = (bottleneck_times, bottleneck_flows) {
             let values: Vec<_> = times
                 .into_iter()
-                .zip(flows.into_iter())
+                .zip(flows)
                 .map(|(t, f)| -> Result<(NonNegativeSeconds, Flow)> {
                     Ok((NonNegativeSeconds::try_from(t)?, Flow::try_from(f)?))
                 })

tch/src/io/csv.rs

@@ -34,7 +34,7 @@ use super::arrow::ToArrow;
 /// Write data that can be converted to arrow format as a CSV file.
 pub fn write_csv<D: ToArrow<J>, const J: usize>(data: &D, output_dir: &Path) -> Result<()> {
     let batches = D::to_arrow(data, true)?;
-    for (name, maybe_batch) in D::names().into_iter().zip(batches.into_iter()) {
+    for (name, maybe_batch) in D::names().into_iter().zip(batches) {
         if let Some(batch) = maybe_batch {
             let filename: PathBuf = [output_dir.to_str().unwrap(), &format!("{name}.csv")]
                 .iter()

tch/src/io/parquet.rs

@@ -30,7 +30,7 @@ use super::arrow::ToArrow;
 /// Writes data that can be converted to arrow format as a parquet file.
 pub fn write_parquet<D: ToArrow<J>, const J: usize>(data: &D, output_dir: &Path) -> Result<()> {
     let batches = D::to_arrow(data, false)?;
-    for (name, maybe_batch) in D::names().into_iter().zip(batches.into_iter()) {
+    for (name, maybe_batch) in D::names().into_iter().zip(batches) {
         if let Some(batch) = maybe_batch {
             let filename: PathBuf = [output_dir.to_str().unwrap(), &format!("{name}.parquet")]
                 .iter()